Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Mar 2019 15:55:30 +0000 (UTC)
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r345135 - head/sys/mips/mips
Message-ID:  <201903141555.x2EFtU3x054287@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brooks
Date: Thu Mar 14 15:55:30 2019
New Revision: 345135
URL: https://svnweb.freebsd.org/changeset/base/345135

Log:
  Remove an unused struct proc *p1 in cpu_fork().
  
  The only reference to p1 after a dead store was in a comment so update
  the comment to refer to td1.
  
  Submitted by:	sbruno
  Differential Revision:	https://reviews.freebsd.org/D16226

Modified:
  head/sys/mips/mips/vm_machdep.c

Modified: head/sys/mips/mips/vm_machdep.c
==============================================================================
--- head/sys/mips/mips/vm_machdep.c	Thu Mar 14 15:07:46 2019	(r345134)
+++ head/sys/mips/mips/vm_machdep.c	Thu Mar 14 15:55:30 2019	(r345135)
@@ -90,10 +90,8 @@ __FBSDID("$FreeBSD$");
 void
 cpu_fork(struct thread *td1, struct proc *p2, struct thread *td2,int flags)
 {
-	struct proc *p1;
 	struct pcb *pcb2;
 
-	p1 = td1->td_proc;
 	if ((flags & RFPROC) == 0)
 		return;
 	/* It is assumed that the vm_thread_alloc called
@@ -103,7 +101,7 @@ cpu_fork(struct thread *td1, struct proc *p2, struct t
 	/* Point the pcb to the top of the stack */
 	pcb2 = td2->td_pcb;
 
-	/* Copy p1's pcb, note that in this case
+	/* Copy td1's pcb, note that in this case
 	 * our pcb also includes the td_frame being copied
 	 * too. The older mips2 code did an additional copy
 	 * of the td_frame, for us that's not needed any



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903141555.x2EFtU3x054287>