From owner-dev-commits-src-main@freebsd.org Fri Mar 12 19:45:17 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3BF655ABB26; Fri, 12 Mar 2021 19:45:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dxx9n1Hk7z4nNp; Fri, 12 Mar 2021 19:45:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 64C082B56E; Fri, 12 Mar 2021 19:45:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 05eac56a0432 - main - lib/msun: Fix x86 GCC6 build after 221622ec0c8e184 To: Dimitry Andric , Alex Richardson Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202103121845.12CIjAub046152@gitrepo.freebsd.org> From: John Baldwin Message-ID: <5f6cc88d-5c16-2438-1aca-b2531d2cb9ae@FreeBSD.org> Date: Fri, 12 Mar 2021 11:45:11 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 19:45:17 -0000 On 3/12/21 11:06 AM, Dimitry Andric wrote: > On 12 Mar 2021, at 19:45, Alex Richardson wrote: >> >> The branch main has been updated by arichardson: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=05eac56a0432d07acd7f159125855437a4dd6259 >> >> commit 05eac56a0432d07acd7f159125855437a4dd6259 >> Author: Alex Richardson >> AuthorDate: 2021-03-12 18:44:42 +0000 >> Commit: Alex Richardson >> CommitDate: 2021-03-12 18:44:44 +0000 >> >> lib/msun: Fix x86 GCC6 build after 221622ec0c8e184 >> >> Apparently GCC only supports arithmetic expressions that use static >> const variables in initializers starting with GCC8. To keep older >> versions happy use a macro instead. >> >> Fixes: 221622ec0c ("lib/msun: Avoid FE_INEXACT for x86 log2l/log10l") >> Reported by: Jenkins >> Reviewed By: imp >> Differential Revision: https://reviews.freebsd.org/D29233 > > Since gcc 6 is EOLed by upstream, why are we still running CI with it? > Isn't it time to upgrade the CI compiler(s), so these kludges don't have > to be used anymore? I'm trying, but we still don't build with GCC 9 yet everywhere. -- John Baldwin