From nobody Sun Jan 5 17:54:50 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YR4hb2hN0z5k2TX for ; Sun, 05 Jan 2025 17:54:55 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc0e.mail.infomaniak.ch (smtp-bc0e.mail.infomaniak.ch [IPv6:2001:1600:4:17::bc0e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YR4hZ08zMz4GKZ for ; Sun, 5 Jan 2025 17:54:54 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=Z4iwFJvU; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 2001:1600:4:17::bc0e as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net; dmarc=pass (policy=reject) header.from=pyret.net Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4YR4hV5LDRzwNV; Sun, 5 Jan 2025 18:54:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1736099690; bh=cDaxXPQmuHYorurI6TcGN0C+IQqYKNa8mleaFO6j1YQ=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=Z4iwFJvU2BnAY9p841DWkwtnDFcOX/FTA/ndJfiPAEOPqZwwK2JSQT9PzEIOvawTn ybKulj1mPTldD3c7z851tBT54i33EbIsM17T19bIgrw5ULo5jHQCXryhuxLLaWmDmK /T3gZgwvjwr1hWQTR2nNlLQ9A/n+Cw5lsYLIRQXq8rvbftV6zaKIjLtFke5ghsReAr M7P6wIcVJpitUvp8BrLOlLLwAodPaTW80JP6xqzVze8FuQzpTwWlo9d/FEit2RoPs2 dF3IfwLV/+FjTLQtgUn8LH0hMvvukeanZ2aPPujMEzSIPVBgWNNNKDvkZ317KXCz9B d+/TzmxgXafqw== Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4YR4hV2ZfwzS1x; Sun, 5 Jan 2025 18:54:50 +0100 (CET) Message-ID: Date: Sun, 05 Jan 2025 18:54:50 +0100 Subject: Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files From: Daniel Engberg Reply-To: Daniel Engberg To: Dirk Meyer Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_" X-WS-User-Origin: eyJpdiI6IldBTE4xZzZuSHY3S2lFeDNxMVgwVUE9PSIsInZhbHVlIjoiOU5aYUFzWjA0RGhzdDZKb1ZmbGhVdz09IiwibWFjIjoiY2NiNWYwOGI2NTExZDE2OWUyNzAwY2RlYjU4ZTQ0YTc4ZWE4MWI2MWZhYWQxYmJmYTgzZjBhYzU1MjE0OTU5NyIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IkUzbE9hbS9ZTjREZDdObkdHVXFRRnc9PSIsInZhbHVlIjoiWW9CNzdxUnhRU21iRFRPYkRhbzJxZz09IiwibWFjIjoiMWNhMzM2OTUxMDQ4YzhkMGUxMTk2YzA1NTQ2NjY5ZWY3Yjg4NDI2MjQ0NDA5ZGU1NDViYjU3MGRkOGI5Y2U1ZiIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.819) References: <202501051538.505FcMKp033044@gitrepo.freebsd.org> <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> In-Reply-To: <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> X-Infomaniak-Routing: alpha X-Rspamd-Queue-Id: 4YR4hZ08zMz4GKZ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.10 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; R_SPF_ALLOW(-0.20)[+ip6:2001:1600:4:17::/64:c]; RCVD_IN_DNSWL_LOW(-0.10)[2001:1600:4:17::bc0e:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@FreeBSD.org]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[pyret.net:+] --_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2025-01-05T18:47:02.000+01:00, Daniel Engberg wrote: >=C2=A0On=C2=A02025-01-05T16:38:28.000+01:00,=C2=A0Dir= k=C2=A0Meyer=C2=A0 >=C2=A0 >=C2=A0wrote: >=C2= =A0 >>=C2=A0=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updat= ed=C2=A0by=C2=A0dinoex: >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0URL: >>= =C2=A0=C2=A0https://cgit.FreeBSD.org/ports/commit/?id=3D942e8b555262a6e684e= f69e96e0036e065fb8211 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0commit=C2= =A0942e8b555262a6e684ef69e96e0036e065fb8211 >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0Author:=C2=A0Dirk=C2=A0Meyer=C2=A0 >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0AuthorDate:=C2=A02025-01-05=C2=A015:38:1= 1=C2=A0+0000 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Commit:=C2=A0Dirk=C2= =A0Meyer=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2= =A0CommitDate:=C2=A02025-01-05=C2=A015:38:11=C2=A0+0000 >>=C2=A0=C2=A0 = >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg:=C2=A0Converts=C2=A0PCD=C2=A0(Kodak= =C2=A0Photo=C2=A0CD)=C2=A0image=C2=A0files >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0--- >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/Makefile= =C2=A0|=C2=A01=C2=A0+ >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdto= jpeg/Makefile=C2=A0|=C2=A033=C2=A0++++++ >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0graphics/pcdtojpeg/distinfo=C2=A0|=C2=A03=C2=A0+ >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/pkg-descr=C2=A0|=C2=A03=C2= =A0+ >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/pkg-plist= =C2=A0|=C2=A0238 >>=C2=A0=C2=A0++++++++++++++++++++++++++++++++++++++++++= + >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A05=C2=A0files=C2=A0changed,=C2= =A0278=C2=A0insertions(+) >=C2=A0 >=C2=A0Hi, >=C2=A0 >=C2=A0Unfortu= nately=C2=A0this=C2=A0appears=C2=A0to=C2=A0be=C2=A0broken=C2=A0in=C2=A0mult= iple=C2=A0ways. >=C2=A0 >=C2=A0Resulting=C2=A0binary=C2=A0doesn't=C2= =A0work=C2=A0(14.2-RELEASE=C2=A0on=C2=A0amd64): >=C2=A0 >=C2=A0pcdtojpe= g=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcd-stock.jpeg >=C2=A0 >=C2=A0Segme= ntation=C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >=C2=A0pcdtojpeg= =C2=A0-r=C2=A04=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-5.jpg >=C2= =A0 >=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >= =C2=A0pcdtojpeg=C2=A0-r=C2=A03=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-= 5.jpg >=C2=A0 >=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped) = >=C2=A0 >=C2=A0pcdtojpeg=C2=A0-r=C2=A05=C2=A0BlownJohn.pcd=C2=A0BlownJohn= -pcdtojpeg-5.jpg >=C2=A0 >=C2=A0Warning:=C2=A0Could=C2=A0not=C2=A0open= =C2=A064Base=C2=A0IPE=C2=A0file >=C2=A0 >=C2=A0while=C2=A0trying=C2= =A0to=C2=A0process=C2=A0ICE=C2=A0file >=C2=A0 >=C2=A0"/home/diizzy/patc= hes-upstream/IPE/BlownJohn/64BASE/INFO.IC" >=C2=A0 >=C2=A0Segmentation= =C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >=C2=A0While=C2=A0documenta= tion=C2=A0is=C2=A0provided=C2=A0a=C2=A0note=C2=A0about=C2=A0this=C2=A0durin= g=C2=A0install >=C2=A0would >=C2=A0 >=C2=A0be=C2=A0helpful. >=C2= =A0 >=C2=A0Image=C2=A0source: >=C2=A0 >=C2=A0https://sembiance.com/fi= leFormatSamples/image/pcd/ >=C2=A0 >=C2=A0CXXFLAGS=C2=A0are=C2=A0droppe= d=C2=A0due=C2=A0to=C2=A0misspelling >=C2=A0 >=C2=A0https://cgit.freebsd= .org/ports/tree/graphics/pcdtojpeg/Makefile?id=3D942e8b555262a6e684ef69e96e= 0036e065fb8211#n23 >=C2=A0 >=C2=A0We=C2=A0likely=C2=A0avoid=C2=A0doing= =C2=A0exercises=C2=A0with=C2=A0tar=C2=A0in=C2=A0post-install=C2=A0sections?= >=C2=A0 >=C2=A0Please=C2=A0sort=C2=A0USES=C2=A0and=C2=A0make=C2=A0it= =C2=A0a=C2=A0separate=C2=A0sections. >=C2=A0 >=C2=A0I'm=C2=A0not=C2= =A0sure=C2=A0if=C2=A0the=C2=A0claims=C2=A0on=C2=A0the=C2=A0page=C2=A0are= =C2=A0still=C2=A0valid=C2=A0as >=C2=A0ImageMagick7 >=C2=A0 >=C2=A0app= ears=C2=A0to=C2=A0work=C2=A0fine=C2=A0as=C2=A0long=C2=A0as=C2=A0you=C2= =A0set=C2=A0colorspace=C2=A0to=C2=A0sRGB=C2=A0during >=C2=A0 >=C2=A0con= version. >=C2=A0 >=C2=A0Best=C2=A0regards, >=C2=A0 >=C2=A0Daniel = Hi, Might also add that ffmpeg also seems to convert without any is= sues however the image is rotated 90 degrees. Best regards, Dan= iel --_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2025-01-05T18:47:02.000+01:00, Daniel Engberg= <daniel.engberg.lists@pyret.net> wrote:
On 2025-01-05T16:38:28.0=
00+01:00, Dirk Meyer <dinoex@FreeBSD.org>
wrot=
e:

  The bra=
nch main has been updated by dinoex:
 
 URL: https://cgit.FreeBSD=
.org/ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb8211
 
 commit 942e8b555262a6e684ef69e96e0036e065fb8211
 
 Author:     Dirk Meyer <dinoex@FreeBSD=
.org>
 
 AuthorDate: 2025-01-05 15:38:11=
 +0000
 
 Commit:     Dirk Meyer <dinoe=
x@FreeBSD.org>
 
 CommitDate: 2025-01-05=
 15:38:11 +0000
 
     graphics/pcdtojpeg: Conv=
erts PCD (Kodak Photo CD) image files
 
 ---
 
  graphics/Makefile            |   1 +
 
  graphics/pcdtojpeg/Makefile  |  33 ++++++
=

 
  graphics/pcdtojpeg/distinfo  |   3 +
 =

  graphics/pcdtojpeg/pkg-descr |   3 +
 
  graphics/pcdtojpeg/pkg-plist | 238 +++++++++++++++++++++++++++++=
++++++++++++++
 
  5 files changed, 278 inserti=
ons(+)
 
Hi,

Unfortunately this appears to be broken in multiple ways.
=


Resulting binary doesn't work (14.2-RELEASE on amd64):<=
br>

pcdtojpeg BlownJohn.pcd BlownJohn-pcd-stock.jp=
eg

Segmentation fault (core dumped)
<=
div>
pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg

Segmentation fault (core dumped)
=

pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg

Segmentation fault (core dumped)

=

pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg
=


Warning: Could not open 64Base IPE file
<=
br>
while trying to process ICE file
"/home/diizzy/=
patches-upstream/IPE/BlownJohn/64BASE/INFO.IC"

Segmentation fault (core dumped)

While docume=
ntation is provided a note about this during install would
be=
 helpful.

Image source:


CXXFLAGS are dropped due to misspell=
ing


We likely avoid doing exercises wi=
th tar in post-install sections?

Please sort U=
SES and make it a separate sections.

I'm not s=
ure if the claims on the page are still valid as ImageMagick7
appears to work fine as long as you set colorspace to sRGB during
conversion.

Best regards,
=

Daniel
Hi,<= br>


Best regards,
<= /div>
Daniel
--_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_--