From owner-cvs-all Thu Feb 24 23:19: 4 2000 Delivered-To: cvs-all@freebsd.org Received: from smtp03.wxs.nl (smtp03.wxs.nl [195.121.6.37]) by hub.freebsd.org (Postfix) with ESMTP id 4D90737BE44; Thu, 24 Feb 2000 23:18:26 -0800 (PST) (envelope-from asmodai@wxs.nl) Received: from daemon.ninth-circle.org ([195.121.196.22]) by smtp03.wxs.nl (Netscape Messaging Server 3.61) with ESMTP id AAA4E46; Fri, 25 Feb 2000 08:18:24 +0100 Received: (from asmodai@localhost) by daemon.ninth-circle.org (8.9.3/8.9.3) id IAA17987; Fri, 25 Feb 2000 08:18:20 +0100 (CET) (envelope-from asmodai) Date: Fri, 25 Feb 2000 08:18:20 +0100 From: Jeroen Ruigrok/Asmodai To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_balloc.c Message-ID: <20000225081820.Q79013@daemon.ninth-circle.org> References: <200002242043.MAA17349@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <200002242043.MAA17349@freefall.freebsd.org>; from dillon@FreeBSD.org on Thu, Feb 24, 2000 at 12:43:22PM -0800 Organisation: Ninth-Circle Enterprises Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk -On [20000225 00:00], Matt Dillon (dillon@FreeBSD.org) wrote: > Fix a 'freeing free block' panic in UFS. The problem occurs when the > filesystem fills up. If the first indirect block exists and FFS is able > to allocate deeper indirect blocks, but is not able to allocate the > data block, FFS improperly unwinds the indirect blocks and leaves a > block pointer hanging to a freed block. This will cause a panic later > when the file is removed. The solution is to properly account for the > first block-pointer-to-an-indirect-block we had to create in a balloc > operation and then unwind it if a failure occurs. I will update my newshub with the latest sources again and see if I get the ffs panics again. JFYI, the box hasn't paniced in over 35 hours now, so the panics do seem to be panics and not faulty hardware. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best The BSD Programmer's Documentation Project When we have not what we like, we must like what we have... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message