From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 23 08:10:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E7E9106564A for ; Tue, 23 Dec 2008 08:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5CD948FC1B for ; Tue, 23 Dec 2008 08:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBN8A3RV068027 for ; Tue, 23 Dec 2008 08:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBN8A3km068026; Tue, 23 Dec 2008 08:10:03 GMT (envelope-from gnats) Date: Tue, 23 Dec 2008 08:10:03 GMT Message-Id: <200812230810.mBN8A3km068026@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Artem Naluzhnyy" Cc: Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Artem Naluzhnyy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 08:10:04 -0000 The following reply was made to PR bin/129814; it has been noted by GNATS. From: "Artem Naluzhnyy" To: "Garrett Cooper" Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5) Date: Tue, 23 Dec 2008 09:28:01 +0200 Hi, On Tue, Dec 23, 2008 at 01:44, Garrett Cooper wrote: > The only issue with this is that: > > if [ -n "${_nice}" ] > > and: > > elif [ -n "${default_nice}" ] > > don't check for valid number values. I'm not sure if we'd want to > throw in that logic or not (or if there's something else in our > rc-scripts that automatically checks for numbers in range)... > > I'd ask (quickly) on hackers@ to see if the change makes sense for a > more widespread review. Actually the same feature for rc.conf file has no integer value syntax check and produces the same error message from nice(1): nice: qwerty: invalid nice value -- Artem Naluzhnyy