From owner-freebsd-bugs Sat Oct 12 7:20: 5 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 602F537B401 for ; Sat, 12 Oct 2002 07:20:03 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A45243EAA for ; Sat, 12 Oct 2002 07:20:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9CEK2Co032391 for ; Sat, 12 Oct 2002 07:20:02 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9CEK2i9032390; Sat, 12 Oct 2002 07:20:02 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD07737B401 for ; Sat, 12 Oct 2002 07:13:30 -0700 (PDT) Received: from webedge2.chello.se (webedge2.chello.se [193.150.195.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18D0443EB3 for ; Sat, 12 Oct 2002 07:13:30 -0700 (PDT) (envelope-from girgen@smtp.chello.se) Received: from palle.girgensohn.se (c213-89-136-93.cm-upc.chello.se [213.89.136.93]) by webedge2.chello.se (Postfix) with ESMTP id 7D2B426651 for ; Sat, 12 Oct 2002 16:12:56 +0200 (MEST) Received: from palle.girgensohn.se (localhost [127.0.0.1]) by palle.girgensohn.se (8.12.6/8.12.6) with ESMTP id g9CEDS3i041612 for ; Sat, 12 Oct 2002 16:13:28 +0200 (CEST) (envelope-from girgen@palle.girgensohn.se) Received: (from girgen@localhost) by palle.girgensohn.se (8.12.6/8.12.6/Submit) id g9CEDRFK041611; Sat, 12 Oct 2002 16:13:27 +0200 (CEST) Message-Id: <200210121413.g9CEDRFK041611@palle.girgensohn.se> Date: Sat, 12 Oct 2002 16:13:27 +0200 (CEST) From: Palle Girgensohn Reply-To: Palle Girgensohn To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/43975: share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 43975 >Category: bin >Synopsis: share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Oct 12 07:20:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Palle Girgensohn >Release: FreeBSD 4.7-RELEASE i386 >Organization: PING PONG >Environment: System: FreeBSD palle.girgensohn.se 4.7-RC FreeBSD 4.7-RC #0: Sun Sep 29 17:21:22 CEST 2002 root@palle.girgensohn.se:/usr/local/obj/usr/src/sys/STORDATAN i386 also applies to CURRENT, afaik. >Description: src/share/sendmail/Makefile uses ${INSTALL} ... -d src/etc/default/make.conf recommends setting INSTALL/install -C , which I find a good thing. Now, since fbsd-4.5.something (?), install -C -d ... fails (previously it silently ignored the `-C'). So, using ${INSTALL} -d in src and ports cannot be allowed anymore; instead we must either not use the INSTALL var, i.e. `install -C', or do the mkdir; chmod; chown troika. >How-To-Repeat: # echo 'INSTALL=install -C' >> /etc/make.conf # cd /usr/src # make installworld the only thing that fails is share/sendmail >Fix: This patch would be much appreciated: Index: Makefile =================================================================== RCS file: /usr/local/ncvs/src/share/sendmail/Makefile,v retrieving revision 1.1.2.6 diff -u -u -r1.1.2.6 Makefile --- Makefile 7 Aug 2002 16:31:51 -0000 1.1.2.6 +++ Makefile 12 Oct 2002 13:57:40 -0000 @@ -23,7 +23,9 @@ copies:: .for dir in ${CFDIRS} - ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 755 -d ${DDIR}/${dir} + ${MKDIR} ${DDIR}/${dir} + ${CHMOD} 755 ${DDIR}/${dir} + ${CHOWN} ${BINOWN}:${BINGRP} ${DDIR}/${dir} .endfor .for file in ${CFFILES} ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 ${SENDMAIL_DIR}/${file} ${DDIR}/${file} >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message