From owner-svn-src-head@freebsd.org Sat Oct 20 22:24:59 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B01DFF89A5; Sat, 20 Oct 2018 22:24:59 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 025FB8D81B; Sat, 20 Oct 2018 22:24:59 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id ED6272448E; Sat, 20 Oct 2018 22:24:58 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w9KMOwFf067165; Sat, 20 Oct 2018 22:24:58 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w9KMOwpv067164; Sat, 20 Oct 2018 22:24:58 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201810202224.w9KMOwpv067164@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: Conrad Meyer Date: Sat, 20 Oct 2018 22:24:58 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r339501 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: cem X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 339501 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 22:24:59 -0000 Author: cem Date: Sat Oct 20 22:24:58 2018 New Revision: 339501 URL: https://svnweb.freebsd.org/changeset/base/339501 Log: netdump: Zone mbufs should be allocated before dump Reviewed by: markj Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D17306 Modified: head/sys/kern/kern_mbuf.c Modified: head/sys/kern/kern_mbuf.c ============================================================================== --- head/sys/kern/kern_mbuf.c Sat Oct 20 22:17:16 2018 (r339500) +++ head/sys/kern/kern_mbuf.c Sat Oct 20 22:24:58 2018 (r339501) @@ -33,8 +33,8 @@ __FBSDID("$FreeBSD$"); #include "opt_param.h" #include +#include #include -#include #include #include #include @@ -409,6 +409,8 @@ nd_buf_import(void *arg, void **store, int count, int struct mbuf *m; int i; + KASSERT(!dumping, ("%s: ran out of pre-allocated mbufs", __func__)); + q = arg; for (i = 0; i < count; i++) { @@ -443,6 +445,8 @@ nd_pack_import(void *arg __unused, void **store, int c struct mbuf *m; void *clust; int i; + + KASSERT(!dumping, ("%s: ran out of pre-allocated mbufs", __func__)); for (i = 0; i < count; i++) { m = m_get(MT_DATA, M_NOWAIT);