From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 18 04:30:46 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33C6F7C5 for ; Thu, 18 Dec 2014 04:30:46 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A5E71816 for ; Thu, 18 Dec 2014 04:30:46 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBI4UjkT015551 for ; Thu, 18 Dec 2014 04:30:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195759] x11/slim fails to honour login.conf Date: Thu, 18 Dec 2014 04:30:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: henry.hu.sh@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 04:30:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195759 --- Comment #9 from Henry Hu --- Ok, I know why. In app.cpp, slim creates child_env, and uses it as the environment of the child. If PAM is not used, the array child_env is manually created and filled with predefined entries. Else, the array is obtained from the pam module. So it seems hard to support all the environment variables that setusercontext() supports. Which environment variables do you really need? LANG and PATH and anything else? setusercontext() supports these env vars: path PATH manpath MANPATH lang LANG charset MM_CHARSET timezone TZ term TERM For PATH, because there is an option called default_path in slim's configuration file, maybe we should just ignore the login.conf. For LANG, we can get the entry "lang" from login database and set it. For TERM, slim sets it from its own version. Anyway, we're using slim so it's not that important. For other variables(TZ, MM_CHARSET, MANPATH), we can do it in a similar way. But it might be still better to use setusercontext() because it sets resource limits, priorities, umask and other things. -- You are receiving this mail because: You are the assignee for the bug.