From owner-svn-src-head@FreeBSD.ORG Tue Jan 6 23:27:08 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A69309E7 for ; Tue, 6 Jan 2015 23:27:08 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E26BFF7 for ; Tue, 6 Jan 2015 23:27:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t06NR800002011 for ; Tue, 6 Jan 2015 23:27:08 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t06NR8kL002008 for svn-src-head@freebsd.org; Tue, 6 Jan 2015 23:27:08 GMT (envelope-from bdrewery) Received: (qmail 38720 invoked from network); 6 Jan 2015 17:27:06 -0600 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 6 Jan 2015 17:27:06 -0600 Message-ID: <54AC6F4E.1000707@FreeBSD.org> Date: Tue, 06 Jan 2015 17:27:10 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Bryan Venteicher , John Nielsen Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 References: <201410100609.s9A690NU067686@svn.freebsd.org> In-Reply-To: OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 23:27:08 -0000 On 1/6/2015 4:00 PM, Bryan Venteicher wrote: > > > On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen > wrote: > > Bryan- > > On Oct 10, 2014, at 12:09 AM, Bryan Venteicher > wrote: > > > Author: bryanv > > Date: Fri Oct 10 06:08:59 2014 > > New Revision: 272886 > > URL: https://svnweb.freebsd.org/changeset/base/272886 > > > > Log: > > Add context pointer and source address to the UDP tunnel callback > > > > These are needed for the forthcoming vxlan implementation. The context > > pointer means we do not have to use a spare pointer field in the inpcb, > > and the source address is required to populate vxlan's forwarding table. > > > > While I highly doubt there is an out of tree consumer of the UDP > > tunneling callback, this change may be a difficult to eventually MFC. > > I noticed this comment while doing an MFC of vxlan to my local tree. > Do you think an MFC to 10-STABLE of this change (and vxlan > generally) will be feasible? Is there precedent for ABI changes like > this being sanctioned? Could symbol versioning help? > > > > I'd like to get some consensus on whether this commit is OK to MFC. With > this commit, vxlan should be an easy to MFC. Breaking ABI will potentially hurt packages. FreeBSD builds packages for the oldest supported release on a branch. If you break ABI in 10.2 while we are building packages for 10.1 then any packages using these interfaces may not work right or result in panics packages with kmods. Please consider that. > > > > > Phabricator: https://reviews.freebsd.org/D383 > > Reviewed by: gnn > > > > Modified: > > head/sys/netinet/sctputil.c > > head/sys/netinet/udp_usrreq.c > > head/sys/netinet/udp_var.h > > head/sys/netinet6/udp6_usrreq.c > > Thanks, > > JN > > -- Regards, Bryan Drewery