From owner-svn-src-all@freebsd.org Tue Sep 22 18:41:08 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 24AB03F2AC5; Tue, 22 Sep 2020 18:41:08 +0000 (UTC) (envelope-from gnikl@justmail.de) Received: from mout2.freenet.de (mout2.freenet.de [IPv6:2001:748:100:40::2:4]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (Client CN "*.freenet.de", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bwqrf5KnFz4RnM; Tue, 22 Sep 2020 18:41:06 +0000 (UTC) (envelope-from gnikl@justmail.de) Received: from [195.4.92.165] (helo=mjail2.freenet.de) by mout2.freenet.de with esmtpa (ID gnikl@justmail.de) (port 25) (Exim 4.92 #3) id 1kKnDr-0000nc-Fx; Tue, 22 Sep 2020 20:41:03 +0200 Received: from localhost ([::1]:47402 helo=mjail2.freenet.de) by mjail2.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.92 #3) id 1kKnDq-0006IO-HZ; Tue, 22 Sep 2020 20:41:02 +0200 Received: from sub0.freenet.de ([195.4.92.119]:36070) by mjail2.freenet.de with esmtpa (ID gnikl@justmail.de) (Exim 4.92 #3) id 1kKnB9-00056m-9C; Tue, 22 Sep 2020 20:38:15 +0200 Received: from p5dc3f1da.dip0.t-ipconnect.de ([93.195.241.218]:49323 helo=localhost) by sub0.freenet.de with esmtpsa (ID gnikl@justmail.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 465) (Exim 4.92 #3) id 1kKnB9-0006J6-5i; Tue, 22 Sep 2020 20:38:15 +0200 Date: Tue, 22 Sep 2020 20:38:11 +0200 From: Gunther Nikl To: Brandon Bergren Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365724 - in head/stand: ficl ficl/powerpc powerpc/ofw Message-ID: <20200922203811.00001097@justmail.de> In-Reply-To: <202009141548.08EFmUxm030455@repo.freebsd.org> References: <202009141548.08EFmUxm030455@repo.freebsd.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originated-At: 93.195.241.218!49323 X-Rspamd-Queue-Id: 4Bwqrf5KnFz4RnM X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of gnikl@justmail.de has no SPF policy when checking 2001:748:100:40::2:4) smtp.mailfrom=gnikl@justmail.de X-Spamd-Result: default: False [-1.46 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[justmail.de]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-0.96)[-0.963]; RECEIVED_SPAMHAUS_PBL(0.00)[93.195.241.218:received]; NEURAL_HAM_MEDIUM(-0.97)[-0.971]; NEURAL_HAM_SHORT(-0.33)[-0.325]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5430, ipnet:2001:748::/32, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_IN_DNSWL_LOW(-0.10)[2001:748:100:40::2:4:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 18:41:08 -0000 Brandon Bergren wrote: > Author: bdragon > Date: Mon Sep 14 15:48:30 2020 > New Revision: 365724 > URL: https://svnweb.freebsd.org/changeset/base/365724 > > [snip] > > Modified: head/stand/ficl/ficl.h > ============================================================================== > --- head/stand/ficl/ficl.h Mon Sep 14 15:20:37 2020 > (r365723) +++ head/stand/ficl/ficl.h Mon Sep 14 15:48:30 > 2020 (r365724) @@ -249,7 +249,7 @@ typedef struct > ficl_system_info FICL_SYSTEM_INFO; ** complement of false... that > unifies logical and bitwise operations ** nicely. > */ > -#define FICL_TRUE ((unsigned long)~(0L)) > +#define FICL_TRUE ((FICL_UNS)~(0LL)) This looks strange. The define should be written as (~(FICL_UNS)0). The size suffix is superfluous if the value is casted anyway. > #define FICL_FALSE (0) > #define FICL_BOOL(x) ((x) ? FICL_TRUE : FICL_FALSE) > > Regards, Gunther