From owner-dev-commits-src-all@freebsd.org  Tue Mar  2 18:56:37 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A93454CCA0;
 Tue,  2 Mar 2021 18:56:37 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DqmZD5fryz3CMC;
 Tue,  2 Mar 2021 18:56:36 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 122IuYnN048087;
 Tue, 2 Mar 2021 10:56:34 -0800 (PST)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 122IuYgV048086;
 Tue, 2 Mar 2021 10:56:34 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202103021856.122IuYgV048086@gndrsh.dnsmgr.net>
Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in
 0b7472b3d8d2.
In-Reply-To: <79dbff79-c40b-4742-98a6-5ce3e2079b70@www.fastmail.com>
To: Brandon Bergren <bdragon@FreeBSD.org>
Date: Tue, 2 Mar 2021 10:56:34 -0800 (PST)
CC: rgrimes@FreeBSD.org, Nathan Whitehorn <nwhitehorn@FreeBSD.org>,
 src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
 dev-commits-src-main@FreeBSD.org
Reply-To: rgrimes@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 4DqmZD5fryz3CMC
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Mar 2021 18:56:37 -0000

> 
> 
> On Tue, Mar 2, 2021, at 12:26 PM, Rodney W. Grimes wrote:
> > 
> > This fails to apply the proper owner/group and mode values
> > using what ever defaults are in place of the process running
> > the build.
> 
> Keep in mind that this is the root of a mounted filesystem in the case where it matters, and the filesystem being mounted there doesn't support proper modes anyway, so the mtree values are a bit irrelevant anyway as the actual control of that is in the fstab.

That assumes the mount is done and/or kept.  My concern is more
of a lack security (aka world writable) /boot/efi getting created
in a distribution that then is *not* mounted for some reason,
either by choice or error.

mkdir should be stricken from use when possible, install -d
should be used instead.

-- 
Rod Grimes                                                 rgrimes@freebsd.org