From owner-svn-src-head@freebsd.org Wed May 30 15:08:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F14D4F74598; Wed, 30 May 2018 15:08:46 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9629A87C49; Wed, 30 May 2018 15:08:46 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 73428499F; Wed, 30 May 2018 15:08:46 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w4UF8k0F008719; Wed, 30 May 2018 15:08:46 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w4UF8kVG008718; Wed, 30 May 2018 15:08:46 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201805301508.w4UF8kVG008718@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Wed, 30 May 2018 15:08:46 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r334383 - head/lib/libdevinfo X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/lib/libdevinfo X-SVN-Commit-Revision: 334383 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 15:08:47 -0000 Author: imp Date: Wed May 30 15:08:46 2018 New Revision: 334383 URL: https://svnweb.freebsd.org/changeset/base/334383 Log: There's no meaningful errno when there's a version mismatch, so use warnx. Also, report the mis-matched versions. Modified: head/lib/libdevinfo/devinfo.c Modified: head/lib/libdevinfo/devinfo.c ============================================================================== --- head/lib/libdevinfo/devinfo.c Wed May 30 14:18:19 2018 (r334382) +++ head/lib/libdevinfo/devinfo.c Wed May 30 15:08:46 2018 (r334383) @@ -125,7 +125,8 @@ devinfo_init(void) } if ((ub_size != sizeof(ubus)) || (ubus.ub_version != BUS_USER_VERSION)) { - warn("kernel bus interface version mismatch"); + warnx("kernel bus interface version mismatch: kernel %d expected %d", + ubus.ub_version, BUS_USER_VERSION); return(EINVAL); } debug("generation count is %d", ubus.ub_generation);