From owner-freebsd-testing@FreeBSD.ORG Sat May 24 20:38:30 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A8434137 for ; Sat, 24 May 2014 20:38:30 +0000 (UTC) Received: from mail-qc0-f179.google.com (mail-qc0-f179.google.com [209.85.216.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6904E2B79 for ; Sat, 24 May 2014 20:38:30 +0000 (UTC) Received: by mail-qc0-f179.google.com with SMTP id r5so1712713qcx.10 for ; Sat, 24 May 2014 13:38:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=UCxrOOGnuELlwzo0FM+2Dc11kLIsqgL5O8gA2CKn7L0=; b=lhGSm9Pnvu5xigPz3ngWqMx27hsNDIyLmqLGdI1tW3rlPHaJU2Hho4pSv5IvJgmOQi g/o/RvjjTQrE3d2FspAdUt1v6TeIyPF0BT2tbrKDyumL9pjIWIRfLhlGJ7LMsznv8y6K EcrzoEYWC5eKWJe1lucRwCgEQy6xhF3jdwGuSaEMqkrAWA5l1AMTHdLr+Xq4ZvbcJxgM KctwrMOL2Mn58s6E4i6Nz6cZH10SSYQCVv5NXHtSnvqEPYYTavGoyRh6jAfGFvNy3y1e YhTn3TxXxV/HGKKnIbXoIfCguya4EQb3skYFxa+t8mPq7JQJC2lpSkcQTPZSSQBs2N3r 8TcA== X-Gm-Message-State: ALoCoQlRj3bgWwgBnyH5d4GUhvSl6EV+dHY/l1zT3vM9k9nPHRuYfEulpiFtCVZwnw/Gi2hgGFMG X-Received: by 10.140.81.146 with SMTP id f18mr18543433qgd.47.1400963909333; Sat, 24 May 2014 13:38:29 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.99 with HTTP; Sat, 24 May 2014 13:38:09 -0700 (PDT) X-Originating-IP: [184.153.117.174] In-Reply-To: References: From: Julio Merino Date: Sat, 24 May 2014 16:38:09 -0400 X-Google-Sender-Auth: sYsL_gFaWa9yyE2ELS2fRgw2j4c Message-ID: Subject: Re: Make atf libraries private To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 May 2014 20:38:30 -0000 => Moving to freebsd-testing. On Thu, May 15, 2014 at 11:16 AM, Julio Merino wrote: > Hello, > > I'd like to make the libatf-c and libatf-c++ private, both in CURRENT _and_ in stable/10. > > These libraries are not built by default yet. Only when WITH_TESTS=yes is defined the libraries are built and installed. > > Once installed, nothing outside of the base system should use them with one exception. The exception are a bunch of atf-related ports (lutok, kyua*) that can use these libraries if and only if the TESTS ports option is enabled. > > So... I don't think moving the library impacts binary compatibility in any significant way. > > Plan: bring atf port up to date, move libraries to the private directory, make tests link to the libraries in the new location and add the old libraries to the obsolete list. > > I will move the libraries sometime next week unless there are objections to be discussed. Or submit earlier if somebody confirms this is OK. Ports have been changed to use devel/atf instead of the library in base so we should now be safe to do this. I have put a patch under https://phabric.freebsd.org/D49 for review and intend to submit it either tomorrow or Monday. If anyone wants to review this, please be my guest; don't forget to add yourself as a reviewer in Phabricator if you do! Instructions in https://wiki.freebsd.org/CodeReview Thanks