From owner-svn-src-head@FreeBSD.ORG Fri Jun 1 02:04:14 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 651261065670 for ; Fri, 1 Jun 2012 02:04:14 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 06B788FC14 for ; Fri, 1 Jun 2012 02:04:13 +0000 (UTC) Received: by vcbfy7 with SMTP id fy7so1263081vcb.13 for ; Thu, 31 May 2012 19:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tomjudge.com; s=google; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=H+PNi2jDT0PVttbfrrqCJL6+n0TwKgOYDMTdgbDNNgA=; b=Ud6BcVh7fmCwcWpCTN2M4DilUyf7R8TV6D9if5ecmJqKuHwsv8p0/g9p/fHOi4FJ6V mTlQp8KDgoDGFSYjmIcnpVkP9MdEO0Sv6wkznSZnjdqpTDN+s5ry++poQUUmFsHqTpib gn2dWUvFgaeUmgIGxF7AnvnQCdGAZ/5F/8Neo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding:x-gm-message-state; bh=H+PNi2jDT0PVttbfrrqCJL6+n0TwKgOYDMTdgbDNNgA=; b=KHUQa0IZ8t7SNY3Aw6i7WndHQ69qV6MNJXhxpxFZ5aUZFpGmI3lbWd5IbOxAzJmgIS hsBQcLDwcvAyVMsQeVgFpzOul/3ApQpnBKrfKOMQrUev65BbMpRMei1UwVV9rG5QeU82 eW/rcEuy2VZ10eUJxP+sgaHB0Epsp4cwuToviK+iHNc7U4pQlvXKVvw8dZy65V0gPKp4 FXk3DjdLZN/ToHbf7S4ao8RzHRkos7BVrdCC7xhA6icMj7V/lP4tKaCws5VN71Vh0hvC 8U0KA9aUWHAMflfaR3wypRZfoEK6llMua0HQZ3BeFz+IETu3nzOFXX/Y+61auBqNl7N8 qhTg== Received: by 10.52.20.143 with SMTP id n15mr723119vde.112.1338516253269; Thu, 31 May 2012 19:04:13 -0700 (PDT) Received: from 192-168-200-48.lan.tj.home.tomjudge.com (ip98-169-143-54.dc.dc.cox.net. [98.169.143.54]) by mx.google.com with ESMTPS id c17sm828784vdj.11.2012.05.31.19.04.11 (version=SSLv3 cipher=OTHER); Thu, 31 May 2012 19:04:12 -0700 (PDT) Sender: Tom Judge Message-ID: <4FC82319.4050307@freebsd.org> Date: Thu, 31 May 2012 22:04:09 -0400 From: Tom Judge Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Doug Barton References: <201205311933.q4VJXpnE060290@svn.freebsd.org> <4FC81AE3.10304@FreeBSD.org> In-Reply-To: <4FC81AE3.10304@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQmTqz44ic8swmmHHkgm0yh9lm5ovGLPmQ6UM1Kl4kYDeee5lahPSw/GP8A4d42TTfKKH+Rb Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler Subject: Re: svn commit: r236362 - head/share/misc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2012 02:04:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 31/05/2012 21:29, Doug Barton wrote: > On 5/31/2012 12:33 PM, Tom Judge wrote: >> - Sort the node list while I'm here. > > This falls under the category of a "whitespace" change, which > should have been done as a separate commit (usually first, then > substantive changes second). > > This is a tiny bit more work for you, but down the road when > someone who is !tj is reviewing the logs, diffs, etc. it really > helps to make the substantive changes stand out. Feedback noted for next time. Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPyCMZAAoJEEJSM9yB4iIWo1cH/130Fb9qDCpI8jJnukHR4EI1 4LJj7q0TLSNoocvB+JleVpO1i3wOuFJX+jj64yTC/BOuMU9Z/FJ7MxoyBTEOXpBO AfUibDN3jquHKIP1eZLZzGYVSOLUg9sXCTG+yryPKfGvaC5iNhkhH3rL3+QBCLzA pQLEG65rcG2yTgzohEejCyJxSBxNl+8O5WmLRUvn+GQlmefBYh2kHyphLAA2iFE+ J8jC7afDZQMg3TA8OhllEcfg3ErbIpzI/CPoHbr+6A2tKTlbzcb1AKUBFkZPLDib 1uSHkEvLUT+ZTsB+8qDiGbbZ42eMlF206jGf5vXdG5AD9C2Xp2zwVVeya8G5o9Y= =LwiQ -----END PGP SIGNATURE-----