From owner-freebsd-multimedia@FreeBSD.ORG  Sat Nov 17 16:42:05 2012
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 17A4278A
 for <freebsd-multimedia@freebsd.org>; Sat, 17 Nov 2012 16:42:05 +0000 (UTC)
 (envelope-from nox@jelal.kn-bremen.de)
Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116])
 by mx1.freebsd.org (Postfix) with ESMTP id C06AB8FC13
 for <freebsd-multimedia@freebsd.org>; Sat, 17 Nov 2012 16:42:04 +0000 (UTC)
Received: by smtp.kn-bremen.de (Postfix, from userid 10)
 id 685A61E007A5; Sat, 17 Nov 2012 17:42:03 +0100 (CET)
Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1])
 by triton8.kn-bremen.de (8.14.4/8.14.4) with ESMTP id qAHGeRiP074564;
 Sat, 17 Nov 2012 17:40:27 +0100 (CET)
 (envelope-from nox@triton8.kn-bremen.de)
Received: (from nox@localhost)
 by triton8.kn-bremen.de (8.14.4/8.14.3/Submit) id qAHGeRhF074563;
 Sat, 17 Nov 2012 17:40:27 +0100 (CET) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Sat, 17 Nov 2012 17:40:27 +0100
To: Rainer Hurling <rhurlin@gwdg.de>
Subject: Re: VLC 2.0.4 audio output module Pulseaudio seg faults
Message-ID: <20121117164027.GA74542@triton8.kn-bremen.de>
References: <50A783EC.3080801@gwdg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50A783EC.3080801@gwdg.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-multimedia@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de>
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Nov 2012 16:42:05 -0000

On Sat, Nov 17, 2012 at 01:32:44PM +0100, Rainer Hurling wrote:
> While vlc versions up to 2.0.3 runs fine using pulseaudio output module,
> unfortunately version 2.0.4 immediately seg faults.
> 
> When I change from pulseaudio output to any other audio output module
> vlc does not crash.
> 
> Is this a know issue? Are there any workarounds? I really need
> pulseaudio for my sound system.
> 
> My box is running on latest 10.0-CURRENT amd64. Please let me know if I
> should provide more information.
> 
Whoops that is a funny bug.  Does the patch below fix it? (put it in
files/patch-modules-audio_output-vlcpulse.c )

 Thanx!
	Juergen

--- modules/audio_output/vlcpulse.c.orig
+++ modules/audio_output/vlcpulse.c
@@ -113,10 +113,12 @@ pa_context *vlc_pa_connect (vlc_object_t
             struct passwd pwbuf, *pw;
             char buf[len];
 
-            if (getpwuid_r (getuid (), &pwbuf, buf, sizeof (buf), &pw) == 0
-             && pw != NULL)
-                pa_proplist_sets (props, PA_PROP_APPLICATION_PROCESS_USER,
-                                  pw->pw_name);
+            if (getpwuid_r (getuid (), &pwbuf, buf, sizeof (buf), &pw) == 0) {
+                if (pw != NULL)
+                    pa_proplist_sets (props, PA_PROP_APPLICATION_PROCESS_USER,
+                                      pw->pw_name);
+                break;
+            }
         }
 
         for (size_t max = sysconf (_SC_HOST_NAME_MAX), len = max % 1024 + 1024;
@@ -124,9 +126,11 @@ pa_context *vlc_pa_connect (vlc_object_t
         {
             char hostname[len];
 
-            if (gethostname (hostname, sizeof (hostname)) == 0)
+            if (gethostname (hostname, sizeof (hostname)) == 0) {
                 pa_proplist_sets (props, PA_PROP_APPLICATION_PROCESS_HOST,
                                   hostname);
+                break;
+            }
         }
 
         const char *session = getenv ("XDG_SESSION_COOKIE");