Date: Mon, 27 Oct 2014 14:27:36 -0400 From: John Baldwin <jhb@freebsd.org> To: Conrad Meyer <cse.cem@gmail.com> Cc: delphij@freebsd.org, Jung-uk Kim <jkim@freebsd.org>, "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org> Subject: Re: Rework hypervisor detection Message-ID: <1436499.c107WK3AT0@ralph.baldwin.cx> In-Reply-To: <CAG6CVpV8i6h6k=rJfNSG3Y2voAjLaQH97FTdO%2BhGGUO7T7rN7A@mail.gmail.com> References: <3183374.mZUFeIh4pp@ralph.baldwin.cx> <CAG6CVpV8i6h6k=rJfNSG3Y2voAjLaQH97FTdO%2BhGGUO7T7rN7A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, October 27, 2014 12:47:13 PM Conrad Meyer wrote: > Hi John, > > I don't have access to phabricator so I'll try and review in email. > > > +#ifdef XEN > > +int vm_guest = VM_GUEST_XEN; > > +#else > > +int vm_guest = VM_GUEST_NO; /* Running as virtual machine guest? */ > > +#endif > > The whitespace between 'int' and 'vm_guest' in the second line seems > wrong (extra space?). Yep, fixed. > For vmware_hvcall() in x86/include/vmware.h, are you sure the inline > assembly is correct? Have you tried the detection on a VMware VM? > VMware's documentation specifies the arguments in a different > order[0], and at Isilon when we tried the port-based detection in a > slightly older revision of CURRENT, it didn't work (IIRC). I don't have VMware handy, but it is a simple copy and paste of existing code in tsc.c. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1436499.c107WK3AT0>