From owner-freebsd-emulation@FreeBSD.ORG Tue Dec 21 08:39:25 2010 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB5D1106566C for ; Tue, 21 Dec 2010 08:39:25 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 84CF88FC16 for ; Tue, 21 Dec 2010 08:39:25 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3AD6F.dip.t-dialin.net [87.179.173.111]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 6775A844027; Tue, 21 Dec 2010 09:39:20 +0100 (CET) Received: from unknown (IO.Leidinger.net [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id 895562938; Tue, 21 Dec 2010 09:39:16 +0100 (CET) Date: Tue, 21 Dec 2010 09:39:15 +0100 From: Alexander Leidinger To: Mark Linimon Message-ID: <20101221093915.0000789e@unknown> In-Reply-To: <20101221035741.GA2710@lonesome.com> References: <20101130192314.GB28560@lonesome.com> <20101201132220.790748omutg2pp6o@webmail.leidinger.net> <20101201153335.GA12007@lonesome.com> <20101202101413.132350uwhyrh6z0o@webmail.leidinger.net> <20101221035741.GA2710@lonesome.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 6775A844027.A54AA X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1, required 6, autolearn=disabled, ALL_TRUSTED -1.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1293525560.87321@rHGu3OKUePSWOF0kEurduA X-EBL-Spam-Status: No Cc: emulation@freebsd.org Subject: Re: fwd: CFR: patch to cleanup usage of SRC_BASE in various ports X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2010 08:39:25 -0000 On Tue, 21 Dec 2010 03:57:41 +0000 Mark Linimon wrote: > >> How about this? We change the override to only work if > >> PACKAGE_BUILDING is set? > > > > This looks like a good plan. > > OK, I thought it was a one-line patch per port, but that's not true. > > Please take a look at the following revised patch: > > http://people.freebsd.org/~linimon/patches/diff.out.srcbase I agree that a patch with less redundancy would be more complex and more unreadable as what you propose here, so no objections from my side. Bye, Alexander.