Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Jul 2019 16:28:58 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Randall Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys
Message-ID:  <4cdc824e-7e71-731d-50d4-c3f6231f9858@FreeBSD.org>
In-Reply-To: <201907102040.x6AKeern006731@repo.freebsd.org>
References:  <201907102040.x6AKeern006731@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 7/10/19 1:40 PM, Randall Stewart wrote:
> Author: rrs
> Date: Wed Jul 10 20:40:39 2019
> New Revision: 349893
> URL: https://svnweb.freebsd.org/changeset/base/349893
> 
> Log:
>   This commit updates rack to what is basically being used at NF as
>   well as sets in some of the groundwork for committing BBR. The
>   hpts system is updated as well as some other needed utilities
>   for the entrance of BBR. This is actually part 1 of 3 more
>   needed commits which will finally complete with BBRv1 being
>   added as a new tcp stack.
>   
>   Sponsored by:	Netflix Inc.
>   Differential Revision:	https://reviews.freebsd.org/D20834

Is it safe for M_TSTMP_LRO to conflict with M_PROTO1?

Also, it seems you changed the copyright range on rack.c from
2016-2019 to just 2016 which I suspect is an accident.

I would suggest using #error here:

#ifndef TCPHPTS
fatal error missing option TCPHSTS in the build;
#endif

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4cdc824e-7e71-731d-50d4-c3f6231f9858>