From owner-freebsd-bugs@FreeBSD.ORG Thu Apr 6 15:20:24 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C268816A420 for ; Thu, 6 Apr 2006 15:20:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 633E843D46 for ; Thu, 6 Apr 2006 15:20:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k36FKNsW023554 for ; Thu, 6 Apr 2006 15:20:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k36FKNEc023553; Thu, 6 Apr 2006 15:20:23 GMT (envelope-from gnats) Date: Thu, 6 Apr 2006 15:20:23 GMT Message-Id: <200604061520.k36FKNEc023553@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: linimon@lonesome.com (Mark Linimon) Cc: Subject: Re: kern/80932: [em] [patch] Degraded performance of em driver X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark Linimon List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2006 15:20:24 -0000 The following reply was made to PR kern/80932; it has been noted by GNATS. From: linimon@lonesome.com (Mark Linimon) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/80932: [em] [patch] Degraded performance of em driver Date: Thu, 6 Apr 2006 10:19:11 -0500 ----- Forwarded message from Marian Durkovic ----- please find the patch for RELENG_6 and MAIN branches in the attachment. RELENG_5 branch needs to be patched with my original patch: http://lists.freebsd.org/pipermail/freebsd-net/2005-May/007161.html Thanks & kind regards, M. -------------------------------------------------------------------------- ---- ---- ---- Marian Durkovic network manager ---- ---- ---- ---- Slovak Technical University Tel: +421 2 524 51 301 ---- ---- Computer Centre, Nam. Slobody 17 Fax: +421 2 524 94 351 ---- ---- 812 43 Bratislava, Slovak Republic E-mail/sip: md@bts.sk ---- ---- ---- -------------------------------------------------------------------------- --- src/sys/dev/em/if_em.c Thu Apr 6 07:56:15 2006 +++ src/sys/dev/em/if_em.c.new Thu Apr 6 08:01:38 2006 @@ -912,11 +912,13 @@ * Packet Buffer Allocation (PBA) * Writing PBA sets the receive portion of the buffer * the remainder is used for the transmit buffer. + * BEWARE: For wirespeed performance, Tx buffer must be able + * to accommodate 2 frames */ switch (adapter->hw.mac_type) { case em_82547: case em_82547_rev_2: /* 82547: Total Packet Buffer is 40K */ - if (adapter->hw.max_frame_size > EM_RXBUFFER_8192) + if (adapter->hw.max_frame_size > 5120) pba = E1000_PBA_22K; /* 22K for Rx, 18K for Tx */ else pba = E1000_PBA_30K; /* 30K for Rx, 10K for Tx */ @@ -926,6 +928,9 @@ break; case em_82571: /* 82571: Total Packet Buffer is 48K */ case em_82572: /* 82572: Total Packet Buffer is 48K */ + if(adapter->hw.max_frame_size > EM_RXBUFFER_8192) + pba = E1000_PBA_30K; /* 30K for Rx, 18K for Tx */ + else pba = E1000_PBA_32K; /* 32K for Rx, 16K for Tx */ break; case em_82573: /* 82573: Total Packet Buffer is 32K */ ----- End forwarded message -----