From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Oct 17 16:50:30 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4969C16A47C for ; Tue, 17 Oct 2006 16:50:30 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F65243D5E for ; Tue, 17 Oct 2006 16:50:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9HGoRDx093586 for ; Tue, 17 Oct 2006 16:50:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9HGoQMW093585; Tue, 17 Oct 2006 16:50:26 GMT (envelope-from gnats) Resent-Date: Tue, 17 Oct 2006 16:50:26 GMT Resent-Message-Id: <200610171650.k9HGoQMW093585@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rich Dawes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2B1716A403 for ; Tue, 17 Oct 2006 16:49:30 +0000 (UTC) (envelope-from rdawes@epstais.com) Received: from epstais.com (epstais.com [69.55.224.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6696C43D53 for ; Tue, 17 Oct 2006 16:49:30 +0000 (GMT) (envelope-from rdawes@epstais.com) Received: from epstais.com (epstais.com [69.55.224.118]) by epstais.com (8.12.9p2/8.12.9) with ESMTP id k9HGnT2e041926 for ; Tue, 17 Oct 2006 09:49:30 -0700 (PDT) (envelope-from rdawes@epstais.com) Received: (from root@localhost) by epstais.com (8.12.9p2/8.12.9/Submit) id k9HGnTRh041925; Tue, 17 Oct 2006 09:49:29 -0700 (PDT) (envelope-from rdawes) Message-Id: <200610171649.k9HGnTRh041925@epstais.com> Date: Tue, 17 Oct 2006 09:49:29 -0700 (PDT) From: Rich Dawes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/104500: [PATCH] multimedia/gstreamer-plugins/Makefile.common breaks make index X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2006 16:50:30 -0000 >Number: 104500 >Category: ports >Synopsis: [PATCH] multimedia/gstreamer-plugins/Makefile.common breaks make index >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Oct 17 16:50:26 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rich Dawes >Release: FreeBSD 4.9-RELEASE-p13-jc2 i386 >Organization: >Environment: System: FreeBSD epstais.com 4.9-RELEASE-p13-jc2 FreeBSD 4.9-RELEASE-p13-jc2 #9: Tue Jun 7 00:30:36 PDT 2005 user@jail16.johncompanies.com:/usr/obj/usr/src/sys/jail16 i386 >Description: Makefile.common uses vars completed at make time with two levels of substitution (e.g. "${gst_${GST_PLUGIN}_SOME_MAKEVAR}"). But make apparently can't grok those within conditionals, at least not when this Makefile.common is included by the various gstreamer-plugin-* Makefiles as part of indexing routines on FreeBSD 4.9 ... (Perhaps 5.x or 6.x makes have added that sort of feature.) Hence, standard indexing breaks, at least on a FreeBSD 4.9 make system. >How-To-Repeat: Run "make describe" from an actual gstreamer-plugins-* port. E.g.: # cd /usr/ports/multimedia/gstreamer-plugins-a52dec # make describe "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 345: Malformed conditional (${gst_${GST_PLUGIN}_GCONF_SCHEMAS}!="") "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 349: Malformed conditional (${gst_${GST_PLUGIN}_USE_SDL}!="") "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 351: if-less endif "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 351: Need an operator "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 372: if-less endif "/usr/ports/audio/gstreamer-plugins-a52dec/../../multimedia/gstreamer-plugins/Makefile.common", line 372: Need an operator make: fatal errors encountered -- cannot continue # >Fix: The following patch removes the extra variable substition from the affected conditionals themselves, by pre-assigning to a dummy variable, and then having the conditional test that. --- Makefile.common.patch begins here --- --- Makefile.common Sat Oct 14 19:52:15 2006 +++ Makefile.common.fixed Tue Oct 17 08:53:11 2006 @@ -342,11 +342,13 @@ EXTRA_LIBS+= ${gst_${GST_PLUGIN}_EXTRA_LIBS} USE_GNOME+= ${gst_${GST_PLUGIN}_USE_GNOME} CONFIGURE_ENV+= ${gst_${GST_PLUGIN}_CONFIGURE_ENV} -.if ${gst_${GST_PLUGIN}_GCONF_SCHEMAS}!="" +str_GST_PLUGIN_GCONF_SCHEMAS= ${gst_${GST_PLUGIN}_GCONF_SCHEMAS} +.if ${str_GST_PLUGIN_GCONF_SCHEMAS}!="" GCONF_SCHEMAS= ${gst_${GST_PLUGIN}_GCONF_SCHEMAS} .endif CONFIGURE_ARGS+=${gst_${GST_PLUGIN}_CONFIGURE_ARGS} -.if ${gst_${GST_PLUGIN}_USE_SDL}!="" +str_GST_PLUGIN_USE_SDL= ${gst_${GST_PLUGIN}_USE_SDL} +.if ${str_GST_PLUGIN_USE_SDL}!="" USE_SDL= ${gst_${GST_PLUGIN}_USE_SDL} .endif USE_GSTREAMER+= ${gst_${GST_PLUGIN}_USE_GSTREAMER} --- Makefile.common.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: