From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Dec 2 06:00:04 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4486106564A for ; Tue, 2 Dec 2008 06:00:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AD2DC8FC0C for ; Tue, 2 Dec 2008 06:00:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mB2604if016247 for ; Tue, 2 Dec 2008 06:00:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mB2604bP016246; Tue, 2 Dec 2008 06:00:04 GMT (envelope-from gnats) Resent-Date: Tue, 2 Dec 2008 06:00:04 GMT Resent-Message-Id: <200812020600.mB2604bP016246@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "G. Paul Ziemba" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F26381065672 for ; Tue, 2 Dec 2008 05:58:07 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id EDF3C8FC0A for ; Tue, 2 Dec 2008 05:58:07 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mB25w7qJ024217 for ; Tue, 2 Dec 2008 05:58:07 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id mB25w7hB024216; Tue, 2 Dec 2008 05:58:07 GMT (envelope-from nobody) Message-Id: <200812020558.mB25w7hB024216@www.freebsd.org> Date: Tue, 2 Dec 2008 05:58:07 GMT From: "G. Paul Ziemba" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/129363: devel/ace build fails if kernel module aio is loaded X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2008 06:00:04 -0000 >Number: 129363 >Category: ports >Synopsis: devel/ace build fails if kernel module aio is loaded >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 02 06:00:04 UTC 2008 >Closed-Date: >Last-Modified: >Originator: G. Paul Ziemba >Release: 7.1-PRERELEASE >Organization: >Environment: FreeBSD hairball.ziemba.us 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Tue Nov 18 13:50:14 PST 2008 root@hairball:/usr/obj/usr/src/sys/GPZ-081118 i386 >Description: devel/ace (ace-5.5.2_2) build works OK if aio(4) is not loaded, but if aio kernel module is loaded, build fails when it attempts to compile tests/Proactor_Test.cpp. This failure occurs because of inconsistency between code in POSIX_CB_Proactor.h (which leaves class ACE_POSIX_CB_Proactor undefined if defined (__FreeBSD__)) and code in Proactor_Test.cpp (which assumes it is defined). There is an identical situation with Proactor_Test_IPV6.cpp as well. In the default case where kernel module aio(4) is not loaded, the ACE configure script does not detect the presence of aio and therefore leaves ACE_HAS_AIO_CALLS undefined. In this case, the test code in Proactor_Test.cpp and Proactor_Test_IPV6.cpp is not compiled, and there is no build failure. >How-To-Repeat: # kldload aio # cd /usr/ports/devel/ace # make clean && make >Fix: The attached patch qualifies the relevant code blocks with "!defined(__FreeBSD__)" to make them consistent with POSIX_CB_Proactor.h. Patch attached with submission follows: --- tests/Proactor_Test.cpp.orig 2006-04-20 00:41:47.000000000 -0700 +++ tests/Proactor_Test.cpp 2008-12-01 11:00:05.000000000 -0800 @@ -253,7 +253,7 @@ break; # endif /* sun */ -# if !defined(__Lynx__) +# if !defined(__Lynx__) && !defined (__FreeBSD__) case CB: ACE_NEW_RETURN (proactor_impl, ACE_POSIX_CB_Proactor (max_op), --- tests/Proactor_Test_IPV6.cpp.orig 2006-04-20 00:41:47.000000000 -0700 +++ tests/Proactor_Test_IPV6.cpp 2008-12-01 17:40:59.000000000 -0800 @@ -253,7 +253,7 @@ break; # endif /* sun */ -# if !defined(__Lynx__) +# if !defined(__Lynx__) && !defined(__FreeBSD__) case CB: ACE_NEW_RETURN (proactor_impl, ACE_POSIX_CB_Proactor (max_op), >Release-Note: >Audit-Trail: >Unformatted: