Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Mar 2014 10:01:00 GMT
From:      Sascha Willuweit <s@rprojekt.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/187785: [patch] (very) old readline callback typedef
Message-ID:  <201403201001.s2KA10K6085331@cgiserv.freebsd.org>
Resent-Message-ID: <201403201010.s2KAA12O014246@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187785
>Category:       ports
>Synopsis:       [patch] (very) old readline callback typedef
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 20 10:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Sascha Willuweit
>Release:        9.2
>Organization:
>Environment:
9.2-RELEASE amd64
>Description:
readline 6.3 removed old "Function" typedef of callback functions. see https://lists.gnu.org/archive/html/bug-readline/2014-03/msg00003.html
>How-To-Repeat:
Compile with readline support
>Fix:
see attached patch

Patch attached with submission follows:

--- ./libcli/smbreadline/smbreadline.c	2014-03-20 10:43:36.000000000 +0100
+++ ./libcli/smbreadline/smbreadline.c.new	2014-03-20 10:44:51.000000000 +0100
@@ -141,7 +141,7 @@
 
 #if HAVE_DECL_RL_EVENT_HOOK
 	if (callback)
-		rl_event_hook = (Function *)callback;
+		rl_event_hook = (rl_hook_func_t *)callback;
 #endif
 	ret = readline(prompt);
 	if (ret && *ret)


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403201001.s2KA10K6085331>