From owner-cvs-all@FreeBSD.ORG Thu Sep 9 18:03:09 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4BC4816A4CE; Thu, 9 Sep 2004 18:03:09 +0000 (GMT) Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net [69.140.212.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3C2043D60; Thu, 9 Sep 2004 18:03:08 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i89I37Rb087007; Thu, 9 Sep 2004 14:03:07 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i89I37cP087006; Thu, 9 Sep 2004 14:03:07 -0400 (EDT) (envelope-from green) Date: Thu, 9 Sep 2004 14:03:07 -0400 From: Brian Fundakowski Feldman To: Warner Losh Message-ID: <20040909180306.GM928@green.homeunix.org> References: <200409091749.i89Hnrnj020760@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200409091749.i89Hnrnj020760@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ugen.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2004 18:03:09 -0000 On Thu, Sep 09, 2004 at 05:49:53PM +0000, Warner Losh wrote: > imp 2004-09-09 17:49:53 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ugen.c > Log: > For the moment, back out my back out of green's 1.87 commit. While it > produced better results for a test program I had here, it didn't > substantially change the number of crashes that I saw. Both the old > code and the new code seemed to produce the same crashes from the usb > layer. Since the new code also solves a close() crash, go with it > until the underlying issues wrt devices going away can be addressed. I'll try making ugen(4) a little smarter about this later today and make the "endpoint open" references to wait upon before detaching along with the "in blocking operation" references. Or just make an open-count. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\