From owner-svn-ports-head@freebsd.org  Tue May  3 03:02:52 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5540B2B436;
 Tue,  3 May 2016 03:02:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id ABEC8144F;
 Tue,  3 May 2016 03:02:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id AB22B1674; Tue,  3 May 2016 03:02:52 +0000 (UTC)
Date: Tue, 3 May 2016 03:02:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Cy Schubert <cy@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r414387 - head/x11/xvattr
Message-ID: <20160503030252.GD52316@FreeBSD.org>
References: <201605010606.u416625F030877@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201605010606.u416625F030877@repo.freebsd.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2016 03:02:52 -0000

On Sun, May 01, 2016 at 06:06:02AM +0000, Cy Schubert wrote:
> New Revision: 414387
> URL: https://svnweb.freebsd.org/changeset/ports/414387
> 
> Log:
>   Make fetchable again.
>   
>   Take maintainership of this port.
> 
> Modified:
>   head/x11/xvattr/Makefile
>   head/x11/xvattr/distinfo
> 
> Modified: head/x11/xvattr/Makefile
> ==============================================================================
> --- head/x11/xvattr/Makefile	Sun May  1 05:29:08 2016	(r414386)
> +++ head/x11/xvattr/Makefile	Sun May  1 06:06:02 2016	(r414387)
> @@ -5,14 +5,12 @@ PORTNAME=	xvattr
>  PORTVERSION=	1.3
>  PORTREVISION=	8
>  CATEGORIES=	x11
> -MASTER_SITES=	ftp://ftp.SpringDaemons.com/soft/ \
> -		http://www.dtek.chalmers.se/groups/dvd/dist/
> +MASTER_SITES=	http://xvattr.sourcearchive.com/downloads/1.3/

We usually do not hardcode version numbers in MASTER_SITES.  While it can
be beneficial to be able to copy-paste the URL with a mouse, having to
touch MASTER_SITES whenever version changes is considered stronger reason
to avoid this.

> +DISTFILES=	xvattr_1.3.orig.tar.gz

Why DISTFILES was used here instead of DISTNAME?  Also, it hardcodes the
PORTNAME and PORTVERSION which is definitely wrong in this case.

./danfe