Date: Tue, 7 Mar 2023 23:25:42 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 109abf744bf7 - main - acpica: do not print warning for missing _ADR Message-ID: <202303072325.327NPgsl064867@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=109abf744bf76a75e952931f28a4c8a0767d5701 commit 109abf744bf76a75e952931f28a4c8a0767d5701 Author: Yuri <yuri@aetern.org> AuthorDate: 2023-03-07 23:22:58 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-03-07 23:25:21 +0000 acpica: do not print warning for missing _ADR Started seeing the following after updating to VMware ESXi 8.0: pcib2: <ACPI Host-PCI bridge> on acpi0 pcib2: could not evaluate _ADR - AE_NOT_FOUND pci2: <ACPI PCI bus> on pcib2 vmx0: <VMware VMXNET3 Ethernet Adapter> ... The virtual NIC works fine, and the code comment suggests that missing _ADR is not something fatal, skip printing the message if status is AE_NOT_FOUND. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/682 --- sys/dev/acpica/acpi_pcib_acpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_pcib_acpi.c b/sys/dev/acpica/acpi_pcib_acpi.c index 6a66dfb5012a..59b4c2bf25bf 100644 --- a/sys/dev/acpica/acpi_pcib_acpi.c +++ b/sys/dev/acpica/acpi_pcib_acpi.c @@ -410,8 +410,9 @@ acpi_pcib_acpi_attach(device_t dev) */ status = acpi_GetInteger(sc->ap_handle, "_ADR", &sc->ap_addr); if (ACPI_FAILURE(status)) { - device_printf(dev, "could not evaluate _ADR - %s\n", - AcpiFormatException(status)); + if (status != AE_NOT_FOUND) + device_printf(dev, "could not evaluate _ADR - %s\n", + AcpiFormatException(status)); sc->ap_addr = -1; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303072325.327NPgsl064867>