From owner-svn-ports-head@FreeBSD.ORG Mon Apr 8 13:24:10 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 831D3954; Mon, 8 Apr 2013 13:24:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by mx1.freebsd.org (Postfix) with ESMTP id 6CF40DCB; Mon, 8 Apr 2013 13:24:08 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id z12so5810002wgg.35 for ; Mon, 08 Apr 2013 06:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=n21wQBbOTBQsRje0B8PUA2FxJ02vYIP7YMZaluJFD2Q=; b=FTyH2IkJQplYae/aOgdfwOrP0UqHUCqa4T94NEoznLb08D0DPlyG4KsQppdOeNQ5/A xAgcz9VC8AF3biQxNCoKySAfLN7GdRUed4HoksRooOkj6i0GVW+IAuMdoTzeM2K0qpb6 ctOYLlAj03n8c4DNTGMPcVvq96fiFqYkJlz3wd2P2Vr0aHrgUqQi96t4IEMhZHBAJWox 5BzVt0RCvQzLwgwSv52RF+i715BilqMMUWZM58ZwCkh7LnknQ17SLJbB2iFgeelpIwmD ZxkPjMUN5TVJJT+VVWYyiygxYD9VrxUpiXhk1Z3Wgf79Wk2BUGTNludHDM8zh/XEUbd5 UQNQ== X-Received: by 10.180.92.229 with SMTP id cp5mr3019234wib.20.1365427447878; Mon, 08 Apr 2013 06:24:07 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id j4sm19659882wiz.10.2013.04.08.06.24.06 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 08 Apr 2013 06:24:07 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 8 Apr 2013 15:24:04 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r315759 - head/graphics/sane-backends Message-ID: <20130408132404.GC33192@ithaqua.etoilebsd.net> References: <201304081226.r38CQlZe065130@svn.freebsd.org> <20130408131824.GA88766@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY" Content-Disposition: inline In-Reply-To: <20130408131824.GA88766@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 13:24:10 -0000 --Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2013 at 01:18:24PM +0000, Alexey Dokuchaev wrote: > On Mon, Apr 08, 2013 at 12:26:47PM +0000, William Grzybowski wrote: > > New Revision: 315759 > > URL: http://svnweb.freebsd.org/changeset/ports/315759 > >=20 > > Log: > > - Fix inverted logic for USB option > > =20 > > @@ -53,7 +53,7 @@ LDFLAGS+=3D -L${LOCALBASE}/lib > > .include "Makefile.man" > > .include > > =20 > > -.if ${PORT_OPTIONS:MUSB} > > +.if empty(PORT_OPTIONS:MUSB) > > CONFIGURE_ARGS+=3D --disable-libusb > > .endif >=20 > While technically empty()-form is equivalent to !-form, the latter should > had been probably used instead, for the following reasons: >=20 > - !-form is given as an example in PH (Example 5-12); > - In the same PH page, in the last note, empty() is only suggested as > alternative syntax when traditional check cannot be used for some rea= son; > - empty()-form is more error prone: it's relatively easy to make mistak= es > like empty(${FOO}) vs. correct emtpy(FOO) which go unnoticed as make(= 1) > does not issue any warning; > - Let's not increase diversity in syntax; most ports use !-form. >=20 > ./danfe While I tend to agree here in that particular case the empty(..) form has b= een chosen to remain consistent with the rest of that port. I do agree that after the freeze a conversion from empty(..) to now more us= ed ! ${...} would be great. regards, Bapt --Bu8it7iiRSEf40bY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFixPQACgkQ8kTtMUmk6ExoVwCfTSnCMKSawC8JS3mfqzIerdTd NUgAoKKQyu9tTMPqxL/78CNDaoksIxyU =dqY3 -----END PGP SIGNATURE----- --Bu8it7iiRSEf40bY--