Date: Mon, 8 Apr 2013 15:24:04 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski <wg@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r315759 - head/graphics/sane-backends Message-ID: <20130408132404.GC33192@ithaqua.etoilebsd.net> In-Reply-To: <20130408131824.GA88766@FreeBSD.org> References: <201304081226.r38CQlZe065130@svn.freebsd.org> <20130408131824.GA88766@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2013 at 01:18:24PM +0000, Alexey Dokuchaev wrote: > On Mon, Apr 08, 2013 at 12:26:47PM +0000, William Grzybowski wrote: > > New Revision: 315759 > > URL: http://svnweb.freebsd.org/changeset/ports/315759 > >=20 > > Log: > > - Fix inverted logic for USB option > > =20 > > @@ -53,7 +53,7 @@ LDFLAGS+=3D -L${LOCALBASE}/lib > > .include "Makefile.man" > > .include <bsd.port.pre.mk> > > =20 > > -.if ${PORT_OPTIONS:MUSB} > > +.if empty(PORT_OPTIONS:MUSB) > > CONFIGURE_ARGS+=3D --disable-libusb > > .endif >=20 > While technically empty()-form is equivalent to !-form, the latter should > had been probably used instead, for the following reasons: >=20 > - !-form is given as an example in PH (Example 5-12); > - In the same PH page, in the last note, empty() is only suggested as > alternative syntax when traditional check cannot be used for some rea= son; > - empty()-form is more error prone: it's relatively easy to make mistak= es > like empty(${FOO}) vs. correct emtpy(FOO) which go unnoticed as make(= 1) > does not issue any warning; > - Let's not increase diversity in syntax; most ports use !-form. >=20 > ./danfe While I tend to agree here in that particular case the empty(..) form has b= een chosen to remain consistent with the rest of that port. I do agree that after the freeze a conversion from empty(..) to now more us= ed ! ${...} would be great. regards, Bapt --Bu8it7iiRSEf40bY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFixPQACgkQ8kTtMUmk6ExoVwCfTSnCMKSawC8JS3mfqzIerdTd NUgAoKKQyu9tTMPqxL/78CNDaoksIxyU =dqY3 -----END PGP SIGNATURE----- --Bu8it7iiRSEf40bY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130408132404.GC33192>