From owner-svn-src-head@FreeBSD.ORG Fri Dec 3 18:12:38 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7E89106566B; Fri, 3 Dec 2010 18:12:38 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 7A52B8FC18; Fri, 3 Dec 2010 18:12:36 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA29285; Fri, 03 Dec 2010 20:12:26 +0200 (EET) (envelope-from avg@freebsd.org) Message-ID: <4CF93309.4050009@freebsd.org> Date: Fri, 03 Dec 2010 20:12:25 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Bruce Evans References: <201012030709.oB379NOH058721@svn.freebsd.org> <20101204045754.T4046@besplex.bde.org> In-Reply-To: <20101204045754.T4046@besplex.bde.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Cran Subject: Re: svn commit: r216143 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 18:12:38 -0000 on 03/12/2010 20:01 Bruce Evans said the following: > On Fri, 3 Dec 2010, Bruce Cran wrote: > >> Log: >> Revert r216134. This checkin broke platforms where bus_space are macros: >> they need to be a single statement, and do { } while (0) doesn't work in this >> situation so revert until a solution can be devised. > > Surprising that do-while doesn't work. I think GCC extension that allows to put statements inside expressions could help here: http://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html#Statement-Exprs I think that we already use the extension in some places. -- Andriy Gapon