From owner-freebsd-arch Tue Oct 24 12:28:14 2000 Delivered-To: freebsd-arch@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 87A2737B479 for ; Tue, 24 Oct 2000 12:28:10 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id e9OJS5n88171; Tue, 24 Oct 2000 13:28:05 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id NAA18224; Tue, 24 Oct 2000 13:28:04 -0600 (MDT) Message-Id: <200010241928.NAA18224@harmony.village.org> To: Takanori Watanabe Subject: Re: NEWCARD/OLDCARD compatibility layer Cc: arch@freebsd.org In-reply-to: Your message of "Tue, 24 Oct 2000 23:38:12 +0900." <200010241438.XAA58776@shidahara1.planet.sci.kobe-u.ac.jp> References: <200010241438.XAA58776@shidahara1.planet.sci.kobe-u.ac.jp> Date: Tue, 24 Oct 2000 13:28:04 -0600 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200010241438.XAA58776@shidahara1.planet.sci.kobe-u.ac.jp> Takanori Watanabe writes: : I looked card_if.m and I think there is a problem:If there is a system : that have neither OLDCARD or NEWCARD layer, module-ifyed driver that : uses NEWCARD/OLDCARD compatibility layer mechanism cannot load because : pccard_compat_probe/pccard_compat_attach is not exist. You are correct. I didn't think this would be a problem, but does impose ordering constraints to module loading which might be undesirable. However, I think that there are other issues with doing this module loading as well that are "silent" killers if done improperly. Reguardless of the other issues, I think this is a step in the right direction. : How about this change? : And ,in child driver side, PCCARD_COMPAT_LAYER should be defined : to use pccard_compat_* function before including "card_if.h". I see no harm in having them defnied all the time for now. I'll test this out when I get some time and report back. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message