From owner-svn-ports-head@FreeBSD.ORG Sun Jul 20 11:31:30 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB45FE0B; Sun, 20 Jul 2014 11:31:30 +0000 (UTC) Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CA032B7A; Sun, 20 Jul 2014 11:31:29 +0000 (UTC) Received: by mail-we0-f171.google.com with SMTP id p10so6441309wes.16 for ; Sun, 20 Jul 2014 04:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=8a6hjX83xlnJHm9T2L7G2FHKbwxYOTMmNWsqTO3m8Rw=; b=stK5edaWfR5xfnVeF+picTRRca7qmofgnsFg7Y0eywokAM0YmbyGs6CCcx6fHEhbue emt9AG/14f4fUujsHq0+cuqJjHit99BVSYN+msLMaK68YPpAI3TdhNCC8TZRzfPI1n+r IleAQ1fFzEHilEKa1DyR3p2OxUanFrs7VvQ9YHJ5K3T6NIq+GgxFQiV/2Hba31rxbRoX eVcFPTxRRhWnyxKyr810VNubi1i3gGIOxsg6VUmtDZYOiQ20jzu9tr1JfVBALsQ50f7z tSdxiab7emwIYDGDs600e/5njQcTL+kVNnmX1KFGVKCbCOome2hwO408l8SNhZrQRF6h YQVA== X-Received: by 10.194.88.168 with SMTP id bh8mr12219178wjb.103.1405855887915; Sun, 20 Jul 2014 04:31:27 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id 20sm29036495wjt.42.2014.07.20.04.31.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jul 2014 04:31:26 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 20 Jul 2014 13:31:24 +0200 From: Baptiste Daroussin To: marino@freebsd.org Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140720113124.GD26778@ivaldir.etoilebsd.net> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8nsIa27JVQLqB7/C" Content-Disposition: inline In-Reply-To: <53CBA770.2010409@marino.st> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, Tijl Coosemans , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2014 11:31:31 -0000 --8nsIa27JVQLqB7/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: > On 7/20/2014 13:22, Tijl Coosemans wrote: > > On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: > >> Author: marino > >> Date: Sun Jul 20 08:15:16 2014 > >> New Revision: 362304 > >> URL: http://svnweb.freebsd.org/changeset/ports/362304 > >> QAT: https://qat.redports.org/buildarchive/r362304/ > >> > >> Log: > >> x11-toolkits/pango: require explicit linking > >> =20 > >> This new configure argument will list all required libraries in the > >> generated pkgconf files. Before any library indirectly pulled in, s= uch > >> as libm, was not listed. > >> =20 > >> This fixes numerous regression in dports and it's more correct anywa= y. > >=20 > > No, this is wrong. Each port should link to the libraries it needs on > > its own. No port should rely on other ports to pull in libraries for > > them. >=20 > Then I guess we really don't need pkgconfig .pc files at all then? > (This is the point of .pc files, it tells how to link. libm is directly > used by pango) >=20 > so no, it is not wrong. The generated pc file was wrong, now it's not. > This is why the configuration argument exists. >=20 The good question is "does pango exposes parts of libm or not?" if yes then= libm should be listed in the libraries of pango.pc is not it should only appears= in the private field. regards, Bapt --8nsIa27JVQLqB7/C Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPLqIwACgkQ8kTtMUmk6EzxOgCfYkYt1YtkSF59uv/IxOYXGCUA vVcAoLZR/E61FPAxS8kKfI3hGk0C2nS+ =s+qN -----END PGP SIGNATURE----- --8nsIa27JVQLqB7/C--