From owner-cvs-src@FreeBSD.ORG Fri Oct 31 14:32:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 601CE16A4CE; Fri, 31 Oct 2003 14:32:24 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87B1B43F75; Fri, 31 Oct 2003 14:32:23 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 6C9252A8EB; Fri, 31 Oct 2003 14:32:23 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: Bruce Evans In-Reply-To: <20031101043729.I1003@gamplex.bde.org> Date: Fri, 31 Oct 2003 14:32:23 -0800 From: Peter Wemm Message-Id: <20031031223223.6C9252A8EB@canning.wemm.org> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Oct 2003 22:32:24 -0000 Bruce Evans wrote: > On Fri, 31 Oct 2003, Ruslan Ermilov wrote: > > > On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote: > > > The system shouldn't have to satisfy cleanness standards of applications > > > that are not maintained by FreeBSD, especially when those standards > > > are bogus (e.g., compiling cleanly with -Wundef). Hopefull all the > > > important corner cases in the system headers are tested by buildworld > > > so that we don't need to enlist the application maintainers to find bugs > > > in system headers. > > > > > Now that buildworld and normal builds behave the same, I tend to agree. > > Count this as "no objection" to revert this. > > Thanks. > > I think -Wsystem-headers needs to be set even when WARNS is not set (or > is 0) for world builds to actually be the same (if toplev.c doesn't set > it by default). Then there would be another aspect of the old problem > that bsd.*.mk aren't entirely suitable for non-FreeBSD builds. I'm a little uneasy about this FWIW. I'll defer to Alexander on this one. If he's ok with the changes you want, then so am I. So long as there is a solution so that Nearly Every Port In Existence doesn't complain about cdefs.h, I will not stand in the way. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5