From owner-svn-src-all@freebsd.org Tue Feb 6 19:35:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB4B0EF654D for ; Tue, 6 Feb 2018 19:35:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 74DD67C8F2 for ; Tue, 6 Feb 2018 19:35:20 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: da42dac0-0b74-11e8-91c6-33ffc249f3e8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id da42dac0-0b74-11e8-91c6-33ffc249f3e8; Tue, 06 Feb 2018 19:35:15 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w16JZDeu019260; Tue, 6 Feb 2018 12:35:13 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1517945713.1366.108.camel@freebsd.org> Subject: Re: svn commit: r328934 - in head: . bin/sh From: Ian Lepore To: rgrimes@freebsd.org, Alex Richardson Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 06 Feb 2018 12:35:13 -0700 In-Reply-To: <201802061925.w16JP4aq017961@pdx.rh.CN85.dnsmgr.net> References: <201802061925.w16JP4aq017961@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 19:35:21 -0000 On Tue, 2018-02-06 at 11:25 -0800, Rodney W. Grimes wrote: > > > > Author: arichardson > > Date: Tue Feb  6 15:41:35 2018 > > New Revision: 328934 > > URL: https://svnweb.freebsd.org/changeset/base/328934 > > > > Log: > >   Don't hardcode /usr/bin as the path for mktemp in build tools > >    > >   It won't work e.g. when crossbuilding from Ubuntu Linux as mktemp > > is in > >   /bin there. > >    > >   Reviewed By: bdrewery > >   Approved By: jhb (mentor) > >   Differential Revision: https://reviews.freebsd.org/D13937 > Would it be better to create the variable MKTEMP to point at > either /bin/mktemp or /usr/bin/mktemp dependent on platform, > there are reasons we use full paths in Makefiles, mostly to > stop /usr/local/bin/foo contimaton, which I believe this > change now opens up, though very slight as I dont know of > a third party mktemp binary. > I don't understand this idea of /usr/local "polluting" a system.  It seems to me exactly the opposite would be the case... if I have found some 3rd party version of mktemp that I like better, it would be installed in /usr/local.  If I went out of my way to install that, then naturally I WANT it to be used.  To me, it's insane that the /usr/local paths are not in front of the base system paths by default, and it's even more insane that the base system works so hard to NOT use the replacements I've installed (even if I've arranged PATH so that the right versions should be used) so that I have to track down why it's using the wrong thing and apply ad-hoc fixes. -- Ian