From owner-svn-src-all@freebsd.org Wed Sep 14 18:14:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58F4FBD5900; Wed, 14 Sep 2016 18:14:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 3C3DB13AC; Wed, 14 Sep 2016 18:14:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 32309139B; Wed, 14 Sep 2016 18:14:18 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id EEDC922837; Wed, 14 Sep 2016 18:14:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id q7B21QvfP6Tn; Wed, 14 Sep 2016 18:14:14 +0000 (UTC) Subject: Re: svn commit: r305634 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 5F26C22832 To: "Simon J. Gerraty" References: <201609090121.u891LZOO023156@repo.freebsd.org> <76524.1473467847@kaos.jnpr.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Wed, 14 Sep 2016 11:14:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <76524.1473467847@kaos.jnpr.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mw2OUWH4Fveo5N2C5XJRvQf5jMKMn65Rd" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2016 18:14:18 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mw2OUWH4Fveo5N2C5XJRvQf5jMKMn65Rd Content-Type: multipart/mixed; boundary="bVD9fPoNnEJC8xwlVnlM5BhIFiJ5rvKXi"; protected-headers="v1" From: Bryan Drewery To: "Simon J. Gerraty" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r305634 - head/share/mk References: <201609090121.u891LZOO023156@repo.freebsd.org> <76524.1473467847@kaos.jnpr.net> In-Reply-To: <76524.1473467847@kaos.jnpr.net> --bVD9fPoNnEJC8xwlVnlM5BhIFiJ5rvKXi Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 9/9/16 5:37 PM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >=20 >>> +# some targets involve old pre-built targets >>> +# ignore mtime of shell >>> +# and mtime of makefiles does not matter in meta mode >>> +.MAKE.META.IGNORE_PATHS +=3D \ >>> + ${MAKEFILE} \ >>> + ${SHELL} \ >>> + ${SYS_MK_DIR} >> >> I think it could be problematic to ignore *.mk changes. The build >=20 > If you're not concerned with build optimization, > this can be disabled - but pretty much any sub-make for which there is = a > .meta file will be out-of-date by any changed to *.mk >=20 >> commands may stay the same, but targets could grow new dependencies. = If >> those dependencies are already "met" then meta mode won't reconsider t= hem. >=20 > I'm not sure how easy it is to accomplish that situation. Can you at least wrap it in something like .if !defined(META_CONSIDER_MK_FILES) ? > =20 >> Consider: >> Build 1: >> bar: >> touch dep >> touch bar >> >> foo: >> touch foo >> >> all: bar foo >> >> In the first build, all generates dep, bar and foo. >> >> Then the code is changed to: >> >> bar: >> touch bar >> >> dep: >> touch notmade >> touch dep >> >> foo: dep >> touch foo >> >> all: foo bar >> >> Now in the second build, all finds bar command changes and rebuilds, >> finds foo command is the same and that dep is already satisfied from t= he >> last build. So 'notmade' is never made. >=20 > Actually given you have missing-meta=3Dyes > target dep would be remade, either because there is no .meta file, or > because its commands changed.=20 > Thus notmade should be. >=20 Good point. --=20 Regards, Bryan Drewery --bVD9fPoNnEJC8xwlVnlM5BhIFiJ5rvKXi-- --Mw2OUWH4Fveo5N2C5XJRvQf5jMKMn65Rd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJX2ZN2AAoJEDXXcbtuRpfP2IkH+QHLT895o/vN5jAs67lE4P2L bXf6PASmfNX2YearLKwHbJ9jAdSSYbazYJ/fBVKaktNZHlD3vMl9ae8uvnNHukmD qvHKzWl7JwDXI9FBapgPOwexTuFDOqYdp8hmsfmngX6rXR/1bo3h0uUfXmO40SQK 5+5ugrjDCG4ENGRAtL9U0Um3mXC9z09FZ28GHzs8Sb6AFEfWXYAqVWWy75bFeXpE v4wum0kjP1HRtnpfj6/7ky1cdWz/JA2YNw9Bu8DZRke5Ay40jvVTPRelW08s6H1l llWPing4OAP7SKYzka5DTz2IqfKA1VDmzsFWPYqJloyPlnUjOzz1FfE+0303qFo= =DIW8 -----END PGP SIGNATURE----- --Mw2OUWH4Fveo5N2C5XJRvQf5jMKMn65Rd--