Date: Sun, 6 Nov 2005 11:33:55 +0100 (CET) From: Anton Berezin <tobez@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/88546: Add a check for a period in IGNORE lines in portlint Message-ID: <20051106103355.A9F54125420@heechee.tobez.org> Resent-Message-ID: <200511061040.jA6AeCHE042675@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 88546
>Category: ports
>Synopsis: Add a check for a period in IGNORE lines in portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 06 10:40:11 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Anton Berezin
>Release: FreeBSD 5.4-STABLE amd64
>Organization:
>Environment:
>Description:
Given an IGNORE string like this:
IGNORE= requires perl 5.6 or above.
The following output is produced by make:
===> p5-XXX-Y.Z requires perl 5.6 or above..
This double-dot is not nice, so it seems reasonable to
teach portlint to deal with it.
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/portlint/Makefile,v
retrieving revision 1.98
diff -u -r1.98 Makefile
--- Makefile 25 Oct 2005 04:48:05 -0000 1.98
+++ Makefile 6 Nov 2005 10:26:47 -0000
@@ -8,8 +8,7 @@
#
PORTNAME= portlint
-PORTVERSION= 2.7.5
-PORTREVISION= 1
+PORTVERSION= 2.7.6
CATEGORIES= devel
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.78
diff -u -r1.78 portlint.pl
--- src/portlint.pl 25 Oct 2005 04:48:06 -0000 1.78
+++ src/portlint.pl 6 Nov 2005 10:26:49 -0000
@@ -1235,6 +1235,11 @@
&perror("WARN: $file [$lineno]: IGNORE messages should not ".
"be quoted.");
}
+ if ($whole =~ /^IGNORE[+?]?=[ \t]+.+?\.\s*$/m) {
+ my $lineno = &linenumber($`);
+ &perror("WARN: $file [$lineno]: IGNORE messages should not ".
+ "end with a period.");
+ }
#
# whole file: PKGNAME
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051106103355.A9F54125420>