From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 6 10:40:12 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA48C16A420 for ; Sun, 6 Nov 2005 10:40:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D13D43D46 for ; Sun, 6 Nov 2005 10:40:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA6AeC4i042676 for ; Sun, 6 Nov 2005 10:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA6AeCHE042675; Sun, 6 Nov 2005 10:40:12 GMT (envelope-from gnats) Resent-Date: Sun, 6 Nov 2005 10:40:12 GMT Resent-Message-Id: <200511061040.jA6AeCHE042675@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anton Berezin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38DF616A436 for ; Sun, 6 Nov 2005 10:33:58 +0000 (GMT) (envelope-from tobez@tobez.org) Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE7B143D48 for ; Sun, 6 Nov 2005 10:33:56 +0000 (GMT) (envelope-from tobez@tobez.org) Received: by heechee.tobez.org (Postfix, from userid 1001) id A9F54125420; Sun, 6 Nov 2005 11:33:55 +0100 (CET) Message-Id: <20051106103355.A9F54125420@heechee.tobez.org> Date: Sun, 6 Nov 2005 11:33:55 +0100 (CET) From: Anton Berezin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/88546: Add a check for a period in IGNORE lines in portlint X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anton Berezin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2005 10:40:12 -0000 >Number: 88546 >Category: ports >Synopsis: Add a check for a period in IGNORE lines in portlint >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Nov 06 10:40:11 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Anton Berezin >Release: FreeBSD 5.4-STABLE amd64 >Organization: >Environment: >Description: Given an IGNORE string like this: IGNORE= requires perl 5.6 or above. The following output is produced by make: ===> p5-XXX-Y.Z requires perl 5.6 or above.. This double-dot is not nice, so it seems reasonable to teach portlint to deal with it. >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/devel/portlint/Makefile,v retrieving revision 1.98 diff -u -r1.98 Makefile --- Makefile 25 Oct 2005 04:48:05 -0000 1.98 +++ Makefile 6 Nov 2005 10:26:47 -0000 @@ -8,8 +8,7 @@ # PORTNAME= portlint -PORTVERSION= 2.7.5 -PORTREVISION= 1 +PORTVERSION= 2.7.6 CATEGORIES= devel MASTER_SITES= # none DISTFILES= # none Index: src/portlint.pl =================================================================== RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v retrieving revision 1.78 diff -u -r1.78 portlint.pl --- src/portlint.pl 25 Oct 2005 04:48:06 -0000 1.78 +++ src/portlint.pl 6 Nov 2005 10:26:49 -0000 @@ -1235,6 +1235,11 @@ &perror("WARN: $file [$lineno]: IGNORE messages should not ". "be quoted."); } + if ($whole =~ /^IGNORE[+?]?=[ \t]+.+?\.\s*$/m) { + my $lineno = &linenumber($`); + &perror("WARN: $file [$lineno]: IGNORE messages should not ". + "end with a period."); + } # # whole file: PKGNAME >Release-Note: >Audit-Trail: >Unformatted: