From owner-freebsd-testing@FreeBSD.ORG Tue Oct 15 05:28:22 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 39CF7B51 for ; Tue, 15 Oct 2013 05:28:22 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [IPv6:2a00:1450:400c:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B8A6B221E for ; Tue, 15 Oct 2013 05:28:21 +0000 (UTC) Received: by mail-wg0-f43.google.com with SMTP id b13so4035963wgh.10 for ; Mon, 14 Oct 2013 22:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iORvd9XabN3ARaYZBgdEL9kgYWY3caZu5KG1cqQMHhk=; b=TY/CiyVAkQKqMr4rNLK/azSw/eXH2al7oNh/xNuIgup/8OKH75SiGZHshgL8aRdrAl tJJ9hjX/OCMB/3mauZBQSy0y0BSNWBoXbZnkk94e/B2wHKPLcoXPwZjfOyPhAkw1tAeQ dQCTEJBmZP0sVdoZs00Zgy3W9BcRL0w0xp6O/8UdR2/rA2gfQPgknt9Ds+WDiqWmLysw ax4PNrVRT4IS7NEBP+xIjJr7xtirArqcJIB4yvkIuINUiWgNcFkfCztOS/pliV6yDIAA 7TtHgm9bLbZo2SJ9cOFdhHIDqG+UjQQtKGe9vKPFEUcvG+Ypa5s37UauyIBNlpX+vdRi Zpjw== MIME-Version: 1.0 X-Received: by 10.180.126.101 with SMTP id mx5mr17000989wib.63.1381814899805; Mon, 14 Oct 2013 22:28:19 -0700 (PDT) Received: by 10.227.121.68 with HTTP; Mon, 14 Oct 2013 22:28:19 -0700 (PDT) In-Reply-To: References: Date: Mon, 14 Oct 2013 22:28:19 -0700 Message-ID: Subject: Re: Refactoring of *.test.mk From: Rui Paulo To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-testing@freebsd.org, Rui Paulo , Garrett Cooper , Simon Gerraty X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 05:28:22 -0000 On 14 October 2013 20:24, Julio Merino wrote: > [Fixing Garrett's address...] > > On Mon, Oct 14, 2013 at 10:44 PM, Julio Merino wrote: > > Hello all, > > > > [ CCing a few people directly that are probably interested. ] > > > > After the recent removal of the deprecated ATF tools from the tree, I > > have been working on a refactoring of the FreeBSD *.test.mk Makefiles > > to add various features that spilled from that change. > > > > The highlights of this work so far: > > > > - Clearly documented the interface of each *.test.mk file by putting > > the list of public variables at the top and adding comments where due. > > > > - Split the logic to build framework-less test programs into a new > > plain.test.mk file. This is in accordance with atf.test.mk, but also > > helps clarifying the code, defining a proper interfac in bsd.test.mk > > and makes some of the other changes simpler. > > > > - Added support to generate both Atffile and Kyuafile files. > > > > - Added support to run the tests using both atf-run and kyua (from > ports). > > > > You can find the relevant patches in: > > http://portal.meroh.net/~jmmv/freebsd-testing/ . > > > > The patches have been generated using quilt so take a look at the > > contents of the 'series' file to see in which order they would need to > > be applied. > > > > Each patch has a description at the top which can later be used as the > > commit log. > > > > Note that, at the moment, this can only be exercised in > > lib/libcrypt/tests/ . I actually wanted to write some tests for > > *.test.mk themselves (!) but I wouldn't want to spend time on that > > before agreeing that this structure is sensible. If it is, I might put > > the effort ;-) See the ones here > > > http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/share/mk/?only_with_tag=MAIN > > to get an idea of what they could look like. > > > > Anybody up for reviewing these patches and sharing their comments? > Looks simple enough. I don't see any problems with it. -- Rui Paulo