From owner-freebsd-scsi@FreeBSD.ORG  Tue Sep 25 15:02:50 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DDC68106566C;
	Tue, 25 Sep 2012 15:02:50 +0000 (UTC) (envelope-from ken@kdm.org)
Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81])
	by mx1.freebsd.org (Postfix) with ESMTP id A36DE8FC0A;
	Tue, 25 Sep 2012 15:02:50 +0000 (UTC)
Received: from nargothrond.kdm.org (localhost [127.0.0.1])
	by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id q8PEsZ1C054388;
	Tue, 25 Sep 2012 08:54:35 -0600 (MDT)
	(envelope-from ken@nargothrond.kdm.org)
Received: (from ken@localhost)
	by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id q8PEsZFx054387;
	Tue, 25 Sep 2012 08:54:35 -0600 (MDT) (envelope-from ken)
Date: Tue, 25 Sep 2012 08:54:35 -0600
From: "Kenneth D. Merry" <ken@freebsd.org>
To: John <jwd@freebsd.org>
Message-ID: <20120925145435.GA52990@nargothrond.kdm.org>
References: <20120915022437.GA90210@FreeBSD.org>
	<20120915023329.GA55292@nargothrond.kdm.org>
	<20120915031305.GA97685@FreeBSD.org>
	<20120915032826.GA63349@nargothrond.kdm.org>
	<20120915040907.GA5458@FreeBSD.org>
	<20120915043938.GA71754@nargothrond.kdm.org>
	<20120916221550.GA63055@FreeBSD.org>
	<20120924172648.GA96855@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120924172648.GA96855@FreeBSD.org>
User-Agent: Mutt/1.4.2i
Cc: FreeBSD iSCSI <freebsd-scsi@freebsd.org>
Subject: Re: How to force a reset of a device (disk) in an enclosre slot
	(PATCH)
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2012 15:02:51 -0000

On Mon, Sep 24, 2012 at 17:26:48 +0000, John wrote:
> Hi Ken,
> 
>    The following patch fixes the problem:
> 
> Index: mps_sas.c
> ===================================================================
> --- mps_sas.c	(revision 240879)
> +++ mps_sas.c	(working copy)
> @@ -918,7 +918,7 @@
>  		cpi->hba_eng_cnt = 0;
>  		cpi->max_target = sassc->sc->facts->MaxTargets - 1;
>  		cpi->max_lun = 255;
> -		cpi->initiator_id = 255;
> +		cpi->initiator_id = sassc->sc->facts->MaxTargets;
>  		strncpy(cpi->sim_vid, "FreeBSD", SIM_IDLEN);
>  		strncpy(cpi->hba_vid, "LSILogic", HBA_IDLEN);
>  		strncpy(cpi->dev_name, cam_sim_name(sim), DEV_IDLEN);
> 
> 
>    I simply set the id to the value after the last possible target
> for the card. Does that seem reasonable to you?

Ahh, good catch!

> 
>    If you don't mind, I'll commit this if there are no objections.

Sure, go ahead and commit it.

>    Thanks to you and others for pointing me in the right direction :-)

No problem, sorry for dropping the ball on looking into this one.  But, I'm
glad you found it!

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG