Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Sep 2012 08:54:35 -0600
From:      "Kenneth D. Merry" <ken@freebsd.org>
To:        John <jwd@freebsd.org>
Cc:        FreeBSD iSCSI <freebsd-scsi@freebsd.org>
Subject:   Re: How to force a reset of a device (disk) in an enclosre slot (PATCH)
Message-ID:  <20120925145435.GA52990@nargothrond.kdm.org>
In-Reply-To: <20120924172648.GA96855@FreeBSD.org>
References:  <20120915022437.GA90210@FreeBSD.org> <20120915023329.GA55292@nargothrond.kdm.org> <20120915031305.GA97685@FreeBSD.org> <20120915032826.GA63349@nargothrond.kdm.org> <20120915040907.GA5458@FreeBSD.org> <20120915043938.GA71754@nargothrond.kdm.org> <20120916221550.GA63055@FreeBSD.org> <20120924172648.GA96855@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 24, 2012 at 17:26:48 +0000, John wrote:
> Hi Ken,
> 
>    The following patch fixes the problem:
> 
> Index: mps_sas.c
> ===================================================================
> --- mps_sas.c	(revision 240879)
> +++ mps_sas.c	(working copy)
> @@ -918,7 +918,7 @@
>  		cpi->hba_eng_cnt = 0;
>  		cpi->max_target = sassc->sc->facts->MaxTargets - 1;
>  		cpi->max_lun = 255;
> -		cpi->initiator_id = 255;
> +		cpi->initiator_id = sassc->sc->facts->MaxTargets;
>  		strncpy(cpi->sim_vid, "FreeBSD", SIM_IDLEN);
>  		strncpy(cpi->hba_vid, "LSILogic", HBA_IDLEN);
>  		strncpy(cpi->dev_name, cam_sim_name(sim), DEV_IDLEN);
> 
> 
>    I simply set the id to the value after the last possible target
> for the card. Does that seem reasonable to you?

Ahh, good catch!

> 
>    If you don't mind, I'll commit this if there are no objections.

Sure, go ahead and commit it.

>    Thanks to you and others for pointing me in the right direction :-)

No problem, sorry for dropping the ball on looking into this one.  But, I'm
glad you found it!

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120925145435.GA52990>