From nobody Tue Mar 28 15:23:14 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PmD382tmqz424Ft; Tue, 28 Mar 2023 15:23:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PmD382Lkzz3NMK; Tue, 28 Mar 2023 15:23:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680016996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=peNEkC63sgz3wLU6+iqMu9YZ+WrSLd6rDMZf9mdew2M=; b=gQ+Ih/BXvXP5uWjSp+Mq5/Knzl+Azi0Cy+iAokA0zeXyhCqRuqkWiXQd+QWrGCk+M5l7te ARjnPcRQlDOBkc/4cBdabp++DS1E4oxX7A08zkfiO1C2Ke9pvOdAZqVUq5TOzUphFfibKv 5W0/twTNT5HuJ2Q8ljpktSpppfuUf/GD9NuXOTidKvXJsup6ef8+C7VeCLb16doaKD4n8f whRjdfiQJzztKtuzQk9ZLP7Jg3TCAvqh8vDAOTQWQOypfv9zd1EDAmV8SDBHoeFKH9SVio Uu50DP4YISQk06tgEQTuO/YPId3i6tvj2+h8Z2fl/tCLINIXj1vRR39AQHaIdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680016996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=peNEkC63sgz3wLU6+iqMu9YZ+WrSLd6rDMZf9mdew2M=; b=XBbT9pY4gvkneem77JcXBhw+VZXofszf15EuwO6p2tmTjrPL31jYMSHg9t7xbdJLUchoAh pRF2vSYX6XikBv0S6i68XQ6BL4bGqGgi5kbJ+Z3S9/NcUFXNRfVKsE3zGcSIeZKyy4bPKU +o4kWLJ9M/JL9vLbhP1Cf9xN3voZcdTv9OCJpc7idIF/HeUJB807hmBBv7LLmAlc/s8R+X npeKwOmQphT/Ung4aEv8JTm3dJxLUZzdfRrx8ocJXczX/ueF/URlhq7H9qbA4UZJkKZa5m RAKFKZ9tk7GhhDLJFdqi2Bw3uEGetBhonKYmc9Ip23z4BQqFatOMlC918Esz7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680016996; a=rsa-sha256; cv=none; b=Lw3Twv93B9FsGvhoezsiptpKda7RmQ9ZYlWFQFivlenOIwHe9k1AmEVVt/iFjsbOPQ9a+x JVeC/w/5M9sI/Rzy6eaYwbCEykPyEvbtqTZxRzisIOuQbIef5fFjef0os+TKEX/JoYMdM/ 2v56EKTxvwOzUO48+sWZJ4Ky5mYR25n5gKGfj0CqocgxhPaJWt81oGUE4MJBcvkdzsin6d 4IXJLHOzzRMkFSQCeXPXryJ4PMEdDE1lh9/Nwpwx01IHQlBXasAqSNbbm8GNDSyCVpxfCc 5Mv3gikJUKrkUOfJSSEV3Fnhq5m2Dv1OcwN5jfbcNSoMv464YbCAvuZli8TksA== Received: from [IPV6:2601:648:8680:16b0:2d4e:165:cff:1385] (unknown [IPv6:2601:648:8680:16b0:2d4e:165:cff:1385]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PmD37550Jzg47; Tue, 28 Mar 2023 15:23:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 28 Mar 2023 08:23:14 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall Content-Language: en-US To: Alan Somers , Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 3/27/23 4:45 PM, Alan Somers wrote: > On Mon, Mar 27, 2023 at 4:39 PM Konstantin Belousov wrote: >> >> The branch main has been updated by kib: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=61194e9852e641d1533cd04a5679d6042ff975d3 >> >> commit 61194e9852e641d1533cd04a5679d6042ff975d3 >> Author: Konstantin Belousov >> AuthorDate: 2023-03-25 23:39:02 +0000 >> Commit: Konstantin Belousov >> CommitDate: 2023-03-27 23:39:26 +0000 >> >> Add kqueue1() syscall >> >> It takes the flags argument. Immediate use is to provide the KQUEUE_CLOEXEC >> flag for kqueue(2). >> >> Reviewed by: emaste, jhb >> Sponsored by: The FreeBSD Foundation >> MFC after: 1 week >> Differential revision: https://reviews.freebsd.org/D39271 > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that > are similar to other syscalls but with a flags argument. > Additionally, Linux has a renameat(2). But I'm not aware of any > syscalls named xxx1. Should we call this new one kqueue2 to follow > the existing convention? See the review, this is consistent with pipe2, accept4 (which is not accept2), and dup3. The number is not a version, but a count of arguments. That is a convention also used in other systems. -- John Baldwin