From nobody Mon Mar 6 13:05:28 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVf2K0knNz3wsrX; Mon, 6 Mar 2023 13:05:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVf2J5f1Hz3GyK; Mon, 6 Mar 2023 13:05:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iO4WmZpEqW/UxtZvGd6NeWYyILvwO8Kj4Pzqlk0ykpA=; b=eAyoi1gsbbO+OzJxxAmSLfDZVf9q87L4Xw7p6KOTCQyFga7po2fabmRXhStgf06HeOdjlV qP2ia7u1pLEoCXTZDVIiouK4vWQonE12Nj6I/EUS5/ykCnFYQW9MZx8qRJv+U9b6eu4BVC GLwJ+ryF9NCR3FMJkIeAydnBg8KHwPoIsimkDjDdZoLFOS4creHZi1wKZkyMmnjY5C4vkK pRMRGtl7LnMv5NzFARayyBvkt8VvG4tt4lMnmrBRTOXHK6QzmyVD9iEWt3N1pdgVWEQIxX VGXJTq6bRhmNJs2pMr6Rmg5m1z4+pZbMPKOO1cIuZNxJsVTLyo6AhTsYi6AO/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iO4WmZpEqW/UxtZvGd6NeWYyILvwO8Kj4Pzqlk0ykpA=; b=UF4+WkM47a+c+HHBxYRJmgMcTy4r8VERc6YdhKh7w1rucwd98NRMUhVOWcCigTrR0V02/c iVNnVof6f9XfO7ezDGNaQZv5lclgdiiKm5YuCKBdS+9/yFJSKbMVZDMqL79u/sHQKvHm3v JL/ovbRq4OcpnIFoE7B3SjbVsjhEiN2HW5kUOAdlocntEqPPP2DUdyoHXiMAdZcc+CngO+ RlYdFzxZmuP+CZMhi6rFfS/T8fLI1/XsloQTJPdrL5CdF6ZKgieNUkQ1B04Zx9DxTV4ZNE cdAq+u/VJU64Kl3OrVvsqYrgnUpvIed2qFnZEZOiaFi45Wvi2gdMFDzkvD/Cxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678107928; a=rsa-sha256; cv=none; b=uiuaRE6AdRdjO6R/o3AXWM4QPgZ+bH1V7Wki+lAaf+oXtTUwwJj+PSadDR7t3FG1zyqTwx 0p/fSvkZglj+sUvx5q8Ta+55uluCBjITVQmCs3waI6bieRRqa6q9O4QElVPKuQU/9Oq90E Ac14IjZ9xkhH22bIQOHdXOp/Kf2pHO0Jwz/9+wqZTpvG8iMEQRf7z9oZaTXsC7481y2Rm0 QgK9wDUC7MrTedlpNwZACpIJXE8+V0zoiHPqjCKgXuWF+y+80R8X9eRAtcgkBq5f3x6SCS zBBouy6nhdIsWTHu5pwXefFSI52d+nazXqsX0gArCFCio5rw1UPQ0Dv3lWJsRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PVf2J4P9sz12pJ; Mon, 6 Mar 2023 13:05:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 326D5Stb079442; Mon, 6 Mar 2023 13:05:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 326D5SuS079441; Mon, 6 Mar 2023 13:05:28 GMT (envelope-from git) Date: Mon, 6 Mar 2023 13:05:28 GMT Message-Id: <202303061305.326D5SuS079441@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: 5c0a03125988 - main - bhyve: don't flush readonly device at blockif_pause List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5c0a03125988b89610f61a1bb2137b0e29d7cf31 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=5c0a03125988b89610f61a1bb2137b0e29d7cf31 commit 5c0a03125988b89610f61a1bb2137b0e29d7cf31 Author: Vitaliy Gusev AuthorDate: 2023-03-06 11:35:17 +0000 Commit: Corvin Köhne CommitDate: 2023-03-06 13:04:07 +0000 bhyve: don't flush readonly device at blockif_pause Reviewed by: corvink, markj MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D38855 --- usr.sbin/bhyve/block_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/block_if.c b/usr.sbin/bhyve/block_if.c index 53a892cbfa3a..6e47c3b7c4da 100644 --- a/usr.sbin/bhyve/block_if.c +++ b/usr.sbin/bhyve/block_if.c @@ -1009,7 +1009,7 @@ blockif_pause(struct blockif_ctxt *bc) pthread_cond_wait(&bc->bc_work_done_cond, &bc->bc_mtx); pthread_mutex_unlock(&bc->bc_mtx); - if (blockif_flush_bc(bc)) + if (!bc->bc_rdonly && blockif_flush_bc(bc)) fprintf(stderr, "%s: [WARN] failed to flush backing file.\r\n", __func__); }