Date: Fri, 11 May 2012 13:37:06 -0700 From: Colin Percival <cperciva@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Gabor Kovesdan <gabor@FreeBSD.org> Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls Message-ID: <4FAD7872.7030503@freebsd.org> In-Reply-To: <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com> References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> <4FAD0DF4.9000609@freebsd.org> <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/11/12 13:08, Warner Losh wrote: > On May 11, 2012, at 9:02 AM, Colin Percival wrote: >> On 05/11/12 05:48, Konstantin Belousov wrote: >>> On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >>>> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>>> unsigned char **cmonths = NULL; >>> >>> Such initializations are useless. You only increase the size of the binary >>> on the disk as the consequence. >> >> I just tested this hypothesis, and found no change in binary size using >> either clang or gcc46. Presumably they're smart enough to ignore explicit >> (and unnecessary) initializations of statics to zero. > > How did you test this? size(1) or ls(1)? If ls, then you may be running into the page rounding of the .text and .data sections... size(1), ls(1)-before-strip(1), and ls(1)-after-strip(1). -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FAD7872.7030503>