From owner-cvs-all@FreeBSD.ORG Mon Jan 26 12:47:23 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C62A16A4CE for ; Mon, 26 Jan 2004 12:47:23 -0800 (PST) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB10843D55 for ; Mon, 26 Jan 2004 12:47:19 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 12959 invoked from network); 26 Jan 2004 20:47:18 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 26 Jan 2004 20:47:18 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i0QKl4M0051451; Mon, 26 Jan 2004 15:47:06 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Jeff Roberson Date: Mon, 26 Jan 2004 15:46:41 -0500 User-Agent: KMail/1.5.4 References: <20040126150636.E36463-100000@mail.chesapeake.net> In-Reply-To: <20040126150636.E36463-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401261546.41842.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: Jeff Roberson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 local_apic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2004 20:47:23 -0000 On Monday 26 January 2004 03:08 pm, Jeff Roberson wrote: > On Mon, 26 Jan 2004, John Baldwin wrote: > > On Sunday 25 January 2004 12:03 am, Jeff Roberson wrote: > > > jeff 2004/01/24 21:03:14 PST > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/i386 local_apic.c > > > Log: > > > - Don't define DETECT_DEADLOCK. I don't know that this code has > > > detected a deadlock in several years. Furthermore, the IPI code is > > > currently protected by a seperate spinlock. This only served to make > > > IPIs twice as expensive as they had to be which severely slowed down > > > the IPI heavy ULE scheduler. > > > > What spinlock? > > Er, based on earlier conversations with you I was under the assumption > that there was a lock around all of the ipi sender code. I must have this > confused with something else. Ah, ok. > > > grep mtx local_apic.c | wc -l > > > > 0 > > > > Some users of the ipi API use a spinlock themselves, but not all, and > > there certainly isn't a global ipi spin lock. According to witness, only > > sparc64 has an ipi spin lock. It might still be a good idea to turn this > > off or perhaps at least half of it. We will lose ipi's on non-XAPIC > > systems if you don't wait for the delivery status to clear before sending > > an IPI. Have you tested this on Pentium II's or earlier? > > My original patch did still poll before transmit. I'll correct this. Thanks. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org