From owner-svn-src-projects@freebsd.org Tue Sep 3 14:06:08 2019 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D058DC305 for ; Tue, 3 Sep 2019 14:06:05 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7z02YYjz4P9m; Tue, 3 Sep 2019 14:06:04 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 52B1B1A0C3; Tue, 3 Sep 2019 14:05:57 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 930656AFA; Tue, 2 Apr 2019 18:45:32 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B1B3719FD; Tue, 2 Apr 2019 18:45:31 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 10B626A82; Tue, 2 Apr 2019 18:45:31 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 4A62B6A7F; Tue, 2 Apr 2019 18:45:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0D0B719F6; Tue, 2 Apr 2019 18:45:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id i17so6817740pfo.6; Tue, 02 Apr 2019 11:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IsoEgyjcvJCxWS1QJSPZ/CCKCOKuSNNmzC4QVFTfpPY=; b=gxrWcsMJh4wVWzvk9I2BBLl6fRVrt02/0fS/RI9V9B+U2HwBNgLfugFc5ohmUuy2KL fsIcP7MpaH+swGY/mQiIwltJy6/KtYo+LRJSjqWJ/bnGlo+K9Sgg8rieI6TOnMxCoeYP XU7fphcvlBA4n2BRaF0iXfKVUW4frgTdezpMhF8xH1onZUod1OauvAj2PcUEdT+cA3Ik KNSV3nQGHSx+/xQDPbj+tYg359I6AGSsIFdLNXV9a6qmrAT5IbAuYmDvCgdJkOm7QQlD vFWChcADLafj9tTnpZAvY07kZ8zOyqb1/3VYAzM4GyHBbtplnUGZK8B8agcjcdHelQwz GDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IsoEgyjcvJCxWS1QJSPZ/CCKCOKuSNNmzC4QVFTfpPY=; b=daHQV6GbQFXvf8BUneaX3kDpFprLZSTKSzvMXGUWnct8A1sTaGyPO9EeEALc+C76Vy xzUQN8HBDuv11v6/8ZdWryrJSIwP6pLsBuzYHcuG3HwjnMSAGjAIlss5vtqUr+ZwnL5Y Zd7ZkP8UR6NaffGfoHyeJzBdOwHPKl2GDUC7rZJ+Yi4396E+Wf8Isiq++n9jQNNPOx+k Auf5k83wQ134+eXRV2musc2emkO8Mh+uxHjSTpZ77ZQLUikHiFUpM1zv/zNgGWiLdErO UWeWsU3SNAAzKmWEabu31wy7pdyg0rFuckLa6aYPhT6mp4jJnGWyQRYzYdWd4F/asVgD McWA== X-Gm-Message-State: APjAAAUzxxNBDO1yWT4bQVUm0/2eQ9tCjgtbxEuMjmLYFZIZD+5yxQ98 gJUkZVnZPt6DJ+3V99Q3p4rf66oa468= X-Google-Smtp-Source: APXvYqzmZZ1bNjuJMOxi0aE3dKMZzaj2T5fvCy7i2t6wIHB1boKPU6NtpYvsniv31xHQKnRKkZ5Vmg== X-Received: by 2002:aa7:8d17:: with SMTP id j23mr834803pfe.62.1554230725842; Tue, 02 Apr 2019 11:45:25 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 10sm20067740pft.83.2019.04.02.11.45.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 11:45:25 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs From: Enji Cooper In-Reply-To: <201904021844.x32Ii1wR041319@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> References: <201904021844.x32Ii1wR041319@repo.freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 3B1B3719FD X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:08 -0000 X-Original-Date: Tue, 2 Apr 2019 11:45:24 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:06:08 -0000 > On Apr 2, 2019, at 11:44 AM, Alan Somers wrote: >=20 > Author: asomers > Date: Tue Apr 2 18:44:01 2019 > New Revision: 345809 > URL: https://svnweb.freebsd.org/changeset/base/345809 >=20 > Log: > fusefs: check return value of wait(2) in fork tests >=20 > Reported by: ngie > Sponsored by: The FreeBSD Foundation >=20 > Modified: > projects/fuse2/tests/sys/fs/fusefs/utils.cc >=20 > Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:09:40 2019 (r345808) > +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:44:01 2019 (r345809) > @@ -321,7 +321,7 @@ out: > /* Signal the child process to go */ > ASSERT_EQ(0, sem_post(sem)) << strerror(errno); >=20 > - wait(&child_status); > + ASSERT_LE(0, wait(&child_status)) << strerror(errno); Don=E2=80=99t you want ASSERT_GE here, since you=E2=80=99re testing that = wait succeeded? -Enji=