From owner-freebsd-bugs@FreeBSD.ORG Sat Dec 8 05:40:02 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0836A16A41B for ; Sat, 8 Dec 2007 05:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DB92E13C4E3 for ; Sat, 8 Dec 2007 05:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB85e1qX069594 for ; Sat, 8 Dec 2007 05:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB85e1jp069593; Sat, 8 Dec 2007 05:40:01 GMT (envelope-from gnats) Resent-Date: Sat, 8 Dec 2007 05:40:01 GMT Resent-Message-Id: <200712080540.lB85e1jp069593@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Weongyo Jeong Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB9C116A417 for ; Sat, 8 Dec 2007 05:33:12 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id DBC2A13C458 for ; Sat, 8 Dec 2007 05:33:12 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lB85X4oi019926 for ; Sat, 8 Dec 2007 05:33:04 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lB85X4hI019925; Sat, 8 Dec 2007 05:33:04 GMT (envelope-from nobody) Message-Id: <200712080533.lB85X4hI019925@www.freebsd.org> Date: Sat, 8 Dec 2007 05:33:04 GMT From: Weongyo Jeong To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/118493: [ndis] a trivial fix when ndis sets `ndis_resource_list' structure. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Dec 2007 05:40:02 -0000 >Number: 118493 >Category: kern >Synopsis: [ndis] a trivial fix when ndis sets `ndis_resource_list' structure. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Dec 08 05:40:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Weongyo Jeong >Release: FreeBSD-CURRENT >Organization: CDNetworks >Environment: >Description: When NDIS try to set `ndis_resource_list' structure in ndis_convert_res() function, handling SYS_RES_MEMORY is weird because it sets prd->u.cprd_port.cprd_start.np_quad not prd->u.cprd_mem.cprd_start.np_quad This difference does not make any problems but made me confusing to read codes. >How-To-Repeat: >Fix: Index: kern_ndis.c =================================================================== RCS file: /data/cvs/src/sys/compat/ndis/kern_ndis.c,v retrieving revision 1.96 diff -u -r1.96 kern_ndis.c --- kern_ndis.c 10 Jun 2007 04:40:13 -0000 1.96 +++ kern_ndis.c 8 Dec 2007 05:05:43 -0000 @@ -644,9 +644,9 @@ CM_RESOURCE_MEMORY_READ_WRITE; prd->cprd_sharedisp = CmResourceShareDeviceExclusive; - prd->u.cprd_port.cprd_start.np_quad = + prd->u.cprd_mem.cprd_start.np_quad = brle->start; - prd->u.cprd_port.cprd_len = brle->count; + prd->u.cprd_mem.cprd_len = brle->count; break; case SYS_RES_IRQ: prd->cprd_type = CmResourceTypeInterrupt; >Release-Note: >Audit-Trail: >Unformatted: