From owner-freebsd-ports@FreeBSD.ORG Mon Feb 3 08:42:17 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFF09428 for ; Mon, 3 Feb 2014 08:42:17 +0000 (UTC) Received: from nschwqsrv03p.mx.bigpond.com (nschwqsrv03p.mx.bigpond.com [61.9.189.237]) by mx1.freebsd.org (Postfix) with ESMTP id 354E11C51 for ; Mon, 3 Feb 2014 08:42:16 +0000 (UTC) Received: from nschwcmgw07p ([61.9.190.167]) by nschwmtas01p.mx.bigpond.com with ESMTP id <20140203073323.BASV18010.nschwmtas01p.mx.bigpond.com@nschwcmgw07p>; Mon, 3 Feb 2014 07:33:23 +0000 Received: from hermes.heuristicsystems.com.au ([121.210.107.115]) by nschwcmgw07p with BigPond Outbound id MjZN1n00P2VR1hD01jZNpY; Mon, 03 Feb 2014 07:33:22 +0000 X-Authority-Analysis: v=2.0 cv=dupZ+ic4 c=1 sm=1 a=kPFzL+aQTxRlsBNBWdEb+Q==:17 a=1YbsQLIiAAQA:10 a=rZfaeqvfVcYA:10 a=8nJEP1OIZ-IA:10 a=GHIR_BbyAAAA:8 a=LOcdf8kKzowA:10 a=6I5d2MoRAAAA:8 a=UWSv7AWgZOkS_caTV90A:9 a=wPNLvfGTeEIA:10 a=kPFzL+aQTxRlsBNBWdEb+Q==:117 Received: from [10.0.5.3] (ewsw01.hs [10.0.5.3]) (authenticated bits=0) by hermes.heuristicsystems.com.au (8.14.5/8.13.6) with ESMTP id s137Wjwd061896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 3 Feb 2014 18:32:46 +1100 (EST) (envelope-from dewayne.geraghty@heuristicsystems.com.au) Message-ID: <52EF4613.9060006@heuristicsystems.com.au> Date: Mon, 03 Feb 2014 18:32:35 +1100 From: Dewayne Geraghty User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: olli hauer , "freebsd-ports@freebsd.org" Subject: Re: bsd.apache.mk Malformed conditional when APACHE_VERSION defined References: <52EE0BD3.8000006@heuristicsystems.com.au> <52EE2337.9080809@gmx.de> In-Reply-To: <52EE2337.9080809@gmx.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 08:42:17 -0000 On 2/02/2014 9:51 PM, olli hauer wrote: > On 2014-02-02 10:11, Dewayne Geraghty wrote: >> I filed a PR against textproc/htdig which should really be against the >> ports systems. >> >> Would someone be kind enough to advise the current method to specify the >> apache version. In ports.conf, I currently use >> USE_APACHE=22 | APACHE_VERSION=22 >> to specify the required version of apache for: >> textproc/htdig >> www/mod_security >> lang/php5 >> >> I believe this PR >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=186364 >> >> which probably should be routed to the ports system, and not textproc/htdig >> >> The error is: >> cd /usr/ports/textproc/htdig && make -V UNIQUENAME >> "/usr/ports/Mk/bsd.apache.mk", line 306: warning: String comparison >> operator should be either == or != >> "/usr/ports/Mk/bsd.apache.mk", line 306: Malformed conditional >> (!empty(_APACHE_VERSION_MINIMUM) && (${_APACHE_VERSION} < >> ${_APACHE_VERSION_MINIMUM})) >> "/usr/ports/Mk/bsd.port.mk", line 6603: if-less endif >> make: fatal errors encountered -- cannot continue >> >> which goes away if APACHE_VERSION isn't used, eg. >> cd /usr/ports/textproc/htdig && make __MAKE_CONF=/dev/null -V UNIQUENAME >> htdig >> > Hi Dewayne, > > APACHE_VERSION is a read only variable in case a port needs to know the > installed / default Apache version -> do not set this variable! > > In case you want to specify a default apache use in etc/make.conf for example > APACHE_PORT=www/apache22 > > See lines 12 - 25 in Mk/bsd.apache.mk > > Olli, Thank-you for pointing me to the right place. I've removed APACHE_VERSION=22; but noted that PERL_VERSION=5.16.3 | PYTHON_VERSION=python2.7 remain valid, which maintains my confusion. With the ongoing changes to the ports system, I've also retained this line in make.conf DEFAULT_VERSIONS=perl5=5.16 python=2.7 python2=2.7 apache=22 Though I suspect that using the latter is preferred and should be the stable way of constricting versions? The last rebuild of all ports occurred on Jan 20, strange that APACHE_VERSION=22 didn't halt that rebuild cycle, as bsd.apache.mk has been changed for 2 months... One of life's mysteries. Regards, Dewayne.