From owner-freebsd-current@FreeBSD.ORG  Wed May 23 17:32:28 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5954F16A4C4;
	Wed, 23 May 2007 17:32:28 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FC8113C4B8;
	Wed, 23 May 2007 17:32:28 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id D1FC546F8C;
	Wed, 23 May 2007 13:32:26 -0400 (EDT)
Date: Wed, 23 May 2007 13:32:26 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Attilio Rao <attilio@freebsd.org>
In-Reply-To: <3bbf2fe10705230954pc9d013dpcbe678cd296b4105@mail.gmail.com>
Message-ID: <20070523133052.O28780@fledge.watson.org>
References: <Pine.LNX.4.64.0705221600300.23596@afrodita.rcub.bg.ac.yu> 
	<20070522134724.L28780@fledge.watson.org>
	<20070522202914.GB64542@bunrab.catwhisker.org>
	<20070523103815.W28780@fledge.watson.org>
	<3bbf2fe10705230954pc9d013dpcbe678cd296b4105@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Goran Gajic <ggajic@afrodita.rcub.bg.ac.yu>, freebsd-current@freebsd.org
Subject: Fixed (was: Re: Kernel hanging after today cvsup at Timecounter
 "TSC)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 May 2007 17:32:28 -0000


On Wed, 23 May 2007, Attilio Rao wrote:

>> I've uploaded the actual stack trace with arguments as
>>
>>   http://www.watson.org/~robert/freebsd/20070523-panic.png
>
> Ok, it seems that the new time_lock spinlock is initialized too late, and 
> infact cpu_initclocks() is called before it is initialized.
>
> It is enough to move the mtx_init() just before the cpu_initclocks() in 
> kern_clock.c::initclocks().
>
> Can someone try that and report if it works?
>
> I'm sorry for that, but I (and presumabily other people testing the patch) 
> never got that problems on all machines we used (probabilly beacause this is 
> just triggered when attaching vgaX).

I've made the change, sucessfully booted, and committed the fix as 
kern_clock.c:1.196.  Thanks!

Robert N M Watson
Computer Laboratory
University of Cambridge
5B