Date: Mon, 31 Dec 2018 15:11:14 +0000 (UTC) From: Kubilay Kocak <koobs@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r488791 - head/devel/py-stevedore Message-ID: <201812311511.wBVFBE2r098509@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: koobs Date: Mon Dec 31 15:11:14 2018 New Revision: 488791 URL: https://svnweb.freebsd.org/changeset/ports/488791 Log: devel/py-stevedor: Add missing runtime dependency stevedor uses pbr, which declares its build time (setup_requires) dependency on it in setup.py. This is used to bootstrap pbr, which the package then uses to declare other dependencies in setup.cfg or requirements.txt files. stevedore declares the following in its requirements.txt file: pbr!=2.1.0,>=2.0.0 # Apache-2.0 six>=1.10.0 # MIT These are install_requires (RUN_DEPENDS), normally declared in setup.py files for most python packages, notably except for those that use pbr. ports r465381 inadvertently removed pbr from RUN_DEPENDS because it wasn't listed in setup.py, which causes all consumers of stevedore to fail at runtime, including multimedia/py-subliminal [1], with the following error: pkg_resources.DistributionNotFound: The 'pbr!=2.1.0,>=2.0.0' distribution was not found stevedore This has happened before [2]. Accordingly, this change re-adds pbr as a RUN_DEPENDS, and adds a comment explaining that it's required at runtime, with references to previous regressions to avoid footshooting in the future. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234529 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197373 PR: 234529 Reported by: Luís Carneiro <luiscarneiro1993 yandex com> Approved by: portmgr (blanket: run time, dependency fix, jfi) MFH: 2018Q4 Modified: head/devel/py-stevedore/Makefile Modified: head/devel/py-stevedore/Makefile ============================================================================== --- head/devel/py-stevedore/Makefile Mon Dec 31 14:21:42 2018 (r488790) +++ head/devel/py-stevedore/Makefile Mon Dec 31 15:11:14 2018 (r488791) @@ -3,6 +3,7 @@ PORTNAME= stevedore PORTVERSION= 1.29.0 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -13,11 +14,16 @@ COMMENT= Manage dynamic plugins for Python application LICENSE= APACHE20 LICENSE_FILE= ${WRKSRC}/LICENSE +# pbr is a RUN_DEPENDS too, just declared elsewhere (requirements.txt) +# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234529 +# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197373 BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pbr>=2.0.0:devel/py-pbr@${PY_FLAVOR} -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>=1.10.0:devel/py-six@${PY_FLAVOR} +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pbr>=2.0.0:devel/py-pbr@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}six>=1.10.0:devel/py-six@${PY_FLAVOR} -NO_ARCH= yes USES= python USE_PYTHON= autoplist distutils + +NO_ARCH= yes .include <bsd.port.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812311511.wBVFBE2r098509>