From owner-svn-src-all@freebsd.org Mon May 16 13:48:05 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50CC9B3DD40; Mon, 16 May 2016 13:48:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1B20C1E98; Mon, 16 May 2016 13:48:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x242.google.com with SMTP id d62so14857504iof.1; Mon, 16 May 2016 06:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Vwd1ad1tDOqUHpFmj0FTm+NcR6F3z6VnoAuYxTPGQ98=; b=fyzaK7UkHpEy8Oks0t7B35Ejs3QcMznYLrevFK9VhOQeBREAby41aZGmkK2DxOBAk1 ydDz3DrIqEqh4x+P0AGuWpmPmx6FDVoZNAUUbjRu9Y4YJZ7pnZwx3V/Iyz0H6zdXTWxc DVjGHsIDBcarbtMWNA89gi2VVSR6hCjJP8P4MYK85Kb3sBXX7MfvW+BqH6WZpxxVKlwm 9+N20LVjEXYq68W23GHSXwSYRcjzXrdN/2MIE8xpVNY2rHFqVU9ll1smLlYv76Viktks k1yZlMLqirVkQN1TpG3Y7C/KZBKIdId2fHpZXo9LPmvdXT4C4G+JgiYoA8NZ9RFk+7On RbiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Vwd1ad1tDOqUHpFmj0FTm+NcR6F3z6VnoAuYxTPGQ98=; b=T4YVrgdCttcGvBCeNA+P1t+2jYWe8AvmP0NJIieuk7cDKQETh027sy+CzYtel0L4k8 LOrrgdqcSrwCiVh8OC74KVqDgU1ItJGFuMO+jzt/0giF28p7rEP4M6d+EpBZlvcaa4ve GDKP6NWvuCmbC3jxsfRCK4kd6ZgDDLgOraJEoMRduDg6f3jdSZNe7gQ4h5/cMa3O647L c2kuqP4+PDpBzL+8znJ9eM/KI0YHREgoisKNO4YZ44yT8h7IoHTw/gliT0m1+lYP3+3F AodN0ghs7FMrflyVhBaYc3lW5jRaBTNY+sgcTrxLrYu5JsRvorBHYA0EEJtOQdLtSdab ps/A== X-Gm-Message-State: AOPr4FXp3Zur8WadIz2mvvkaXTKC2VJf70jJFHam7zWamap2O/IMrpLJNdwRzxmAIWhWvv+afTZp2n/H85QBcw== X-Received: by 10.107.31.146 with SMTP id f140mr20017435iof.180.1463406484429; Mon, 16 May 2016 06:48:04 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.27.197 with HTTP; Mon, 16 May 2016 06:47:44 -0700 (PDT) In-Reply-To: <201605160834.u4G8YH1C000850@repo.freebsd.org> References: <201605160834.u4G8YH1C000850@repo.freebsd.org> From: Ed Maste Date: Mon, 16 May 2016 09:47:44 -0400 X-Google-Sender-Auth: WjEbwDnozkKkAYWbf5sIfR8hKTI Message-ID: Subject: Re: svn commit: r299926 - head/lib/libpam/modules/pam_unix To: Don Lewis Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 13:48:05 -0000 On 16 May 2016 at 04:34, Don Lewis wrote: > Author: truckman > Date: Mon May 16 08:34:17 2016 > New Revision: 299926 > URL: https://svnweb.freebsd.org/changeset/base/299926 > > Log: > Hoist the getpwnam() call outside the first if/else block in > pam_sm_chauthtok(). Set user = getlogin() inside the true > branch so that it is initialized for the following PAM_LOG() > call. This is how it is done in pam_sm_authenticate(). Unfortunately this triggers a warning on powerpc/powerpc64: /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_unix/pam_unix.c: In function 'pam_sm_chauthtok': /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_unix/pam_unix.c:278: warning: 'retval' may be used uninitialized in this function I don't see why GCC warns now and did not before, though.