Date: Fri, 21 Sep 2001 12:50:59 +0200 From: Thomas Zenker <thz@Lennartz-electronic.de> To: Antony T Curtis <antony@dp.abacus.co.uk> Cc: stable@freebsd.org Subject: Re: mergemaster goes postal / MAKEDEV problems Message-ID: <20010921125059.A19142@mezcal.tue.le> In-Reply-To: <3BAA0757.BF52C720@dp.abacus.co.uk>; from antony@dp.abacus.co.uk on Thu, Sep 20, 2001 at 04:12:23PM %2B0100 References: <E15jveS-0008Uc-00@rip.psg.com> <3BAA3B47.6000308@gmx.net> <3BAA0757.BF52C720@dp.abacus.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 20, 2001 at 04:12:23PM +0100, Antony T Curtis wrote: > Michael Nottebrock wrote: > > > > Randy Bush wrote: > > > happened on three separate systems cvsupped this afternoon > > > > > > [...] > > > > > > MAKEDEV: arith: syntax error: à [...] > > > > > > [...] > > > > Looks to me as if this is a really old bug surfacing here. Reference > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=30637 > > > > and > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=24443 > > Is the above PR a reasonable fix and is it safe for people to apply this > change to /usr/src/bin/sh/expand.c ? > > If it is a good fix - any chance it would be committed? yes, that's it: Index: expand.c =================================================================== RCS file: /usr/cvs/FreeBSD/src/bin/sh/expand.c,v retrieving revision 1.31.2.1 diff -u -r1.31.2.1 expand.c --- expand.c 2000/06/14 13:42:25 1.31.2.1 +++ expand.c 2001/09/21 10:49:11 @@ -397,7 +397,7 @@ CHECKSTRSPACE(12 - 2, expdest); USTPUTC('\0', expdest); start = stackblock(); - p = expdest; + p = expdest - 1; while (*p != CTLARI && p >= start) --p; if (*p != CTLARI) -- Thomas Zenker c/o Lennartz electronic GmbH Bismarckstrasse 136, D-72072 Tuebingen, Germany Phone: +49-(0)7071-93550 Email: thz@lennartz-electronic.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010921125059.A19142>