From owner-p4-projects@FreeBSD.ORG Mon Aug 25 20:47:33 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 89F3F1065696; Mon, 25 Aug 2008 20:47:33 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CFF2106568C for ; Mon, 25 Aug 2008 20:47:33 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2F51E8FC1A for ; Mon, 25 Aug 2008 20:47:33 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7PKlXHf000242 for ; Mon, 25 Aug 2008 20:47:33 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7PKlXx3000240 for perforce@freebsd.org; Mon, 25 Aug 2008 20:47:33 GMT (envelope-from hselasky@FreeBSD.org) Date: Mon, 25 Aug 2008 20:47:33 GMT Message-Id: <200808252047.m7PKlXx3000240@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 148444 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2008 20:47:33 -0000 http://perforce.freebsd.org/chv.cgi?CH=148444 Change 148444 by hselasky@hselasky_laptop001 on 2008/08/25 20:47:07 Small bugfix. We should clear the Out-endpoint after the In-endpoint according to USB Mass Storage specification chapter 5.3.4 about Reset Recovery. ATA-USB has this right. Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#6 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#6 (text+ko) ==== @@ -1743,7 +1743,7 @@ umass_t_bbb_reset3_callback(struct usb2_xfer *xfer) { umass_t_bbb_data_clear_stall_callback(xfer, UMASS_T_BBB_COMMAND, - UMASS_T_BBB_DATA_READ); + UMASS_T_BBB_DATA_WRITE); return; }